[PATCH -next] net: ethernet: nb8800: fix error handling of nb8800_probe()

Subsystems: networking drivers, the rest

STALE3673d

3 messages, 3 authors, 2016-07-20 · open the first message on its own page

[PATCH -next] net: ethernet: nb8800: fix error handling of nb8800_probe()

From: Wei Yongjun <hidden>
Date: 2016-07-19 11:33:59

From: Wei Yongjun <redacted>

In ops->reset() error handling case, clk_disable_unprepare() is missed
before return from this function.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/ethernet/aurora/nb8800.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
index 2dcb8c7..0d4ea92 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -1419,7 +1419,7 @@ static int nb8800_probe(struct platform_device *pdev)
 	if (ops && ops->reset) {
 		ret = ops->reset(dev);
 		if (ret)
-			goto err_free_dev;
+			goto err_disable_clk;
 	}
 
 	bus = devm_mdiobus_alloc(&pdev->dev);

Re: [PATCH -next] net: ethernet: nb8800: fix error handling of nb8800_probe()

From: Måns Rullgård <hidden>
Date: 2016-07-19 11:37:21

Wei Yongjun [off-list ref] writes:
From: Wei Yongjun <redacted>

In ops->reset() error handling case, clk_disable_unprepare() is missed
before return from this function.

Signed-off-by: Wei Yongjun <redacted>
Acked-by: Mans Rullgard <redacted>
quoted hunk
---
 drivers/net/ethernet/aurora/nb8800.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
index 2dcb8c7..0d4ea92 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -1419,7 +1419,7 @@ static int nb8800_probe(struct platform_device *pdev)
 	if (ops && ops->reset) {
 		ret = ops->reset(dev);
 		if (ret)
-			goto err_free_dev;
+			goto err_disable_clk;
 	}

 	bus = devm_mdiobus_alloc(&pdev->dev);
-- 
Måns Rullgård

Re: [PATCH -next] net: ethernet: nb8800: fix error handling of nb8800_probe()

From: David Miller <davem@davemloft.net>
Date: 2016-07-20 21:48:19

From: Wei Yongjun <redacted>
Date: Tue, 19 Jul 2016 11:33:10 +0000
From: Wei Yongjun <redacted>

In ops->reset() error handling case, clk_disable_unprepare() is missed
before return from this function.

Signed-off-by: Wei Yongjun <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help