[PATCH -next] net: ethernet: bgmac: Fix return value check in bgmac_probe()

Subsystems: broadcom iproc gbit ethernet driver, networking drivers, the rest

STALE3678d

2 messages, 2 authors, 2016-07-12 · open the first message on its own page

[PATCH -next] net: ethernet: bgmac: Fix return value check in bgmac_probe()

From: <hidden>
Date: 2016-07-12 00:17:50

From: Wei Yongjun <redacted>

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/ethernet/broadcom/bgmac-platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bgmac-platform.c b/drivers/net/ethernet/broadcom/bgmac-platform.c
index 7a8f7ef..1a2d841 100644
--- a/drivers/net/ethernet/broadcom/bgmac-platform.c
+++ b/drivers/net/ethernet/broadcom/bgmac-platform.c
@@ -141,7 +141,7 @@ static int bgmac_probe(struct platform_device *pdev)
 	}
 
 	bgmac->plat.idm_base = devm_ioremap_resource(&pdev->dev, regs);
-	if (!bgmac->plat.idm_base) {
+	if (IS_ERR(bgmac->plat.idm_base)) {
 		dev_err(&pdev->dev, "Unable to map idm resource\n");
 		return PTR_ERR(bgmac->plat.idm_base);
 	}

Re: [PATCH -next] net: ethernet: bgmac: Fix return value check in bgmac_probe()

From: David Miller <davem@davemloft.net>
Date: 2016-07-12 02:52:21

From: weiyj_lk@163.com
Date: Tue, 12 Jul 2016 00:17:28 +0000
From: Wei Yongjun <redacted>

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Signed-off-by: Wei Yongjun <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help