Re: [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template

2 messages, 2 authors, 2016-07-13 · open the first message on its own page

Re: [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2016-06-29 07:17:41

On Tue, 2016-06-28 at 14:13 +0300, Yaniv Machani wrote:
 net/mac80211/mesh.c | 33 ++++++++++++++++++++++++++++++++-
 net/mac80211/util.c |  3 ---
 net/wireless/mesh.c |  2 +-
That's not a good patch - one change is mac80211 and the other
cfg80211.
-	.ht_opmode = IEEE80211_HT_OP_MODE_PROTECTION_NONHT_MIXED,
+	.ht_opmode = IEEE80211_HT_OP_MODE_PROTECTION_NONE,
How are you planning to comply with 802.11 now?


The HT Protection field in a mesh STA may be set to no protection mode
only if
— All STAs detected in the primary or the secondary channel are HT
  STAs, and
— All mesh STA members of this MBSS that are one-hop neighbors of the
  transmitting mesh STA are either:
  — 20/40 MHz HT mesh STAs in a 20/40 MHz MBSS, or
  — 20 MHz HT mesh STAs in a 20 MHz MBSS.

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template

From: Machani, Yaniv <hidden>
Date: 2016-07-13 11:15:55

On Wed, Jun 29, 2016 at 10:17:35, Johannes Berg wrote:
Cc: Kama, Meirav
Subject: Re: [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon 
template

On Tue, 2016-06-28 at 14:13 +0300, Yaniv Machani wrote:
quoted
 net/mac80211/mesh.c | 33 ++++++++++++++++++++++++++++++++-
 net/mac80211/util.c |  3 ---
 net/wireless/mesh.c |  2 +-
That's not a good patch - one change is mac80211 and the other cfg80211.
quoted
-	.ht_opmode =
IEEE80211_HT_OP_MODE_PROTECTION_NONHT_MIXED,
quoted
+	.ht_opmode = IEEE80211_HT_OP_MODE_PROTECTION_NONE,
How are you planning to comply with 802.11 now?
Good point, this changed should be removed.
The reason for this change was that we've noticed a difference between mesh beacon (built by the mac80211) and mesh actions (built by the supplicant) in the HT information IE.
In beacons the HT operational mode is Mixed Mode (0x11)  while in actions it is None (0x00). 
After a second look, it seems that it's the Supplicant that doesn't set the default value correctly.

We'll send an updated patch for it.
Thanks,
Yaniv
The HT Protection field in a mesh STA may be set to no protection mode 
only if — All STAs detected in the primary or the secondary channel 
are HT
  STAs, and
— All mesh STA members of this MBSS that are one-hop neighbors of the
  transmitting mesh STA are either:
  — 20/40 MHz HT mesh STAs in a 20/40 MHz MBSS, or
  — 20 MHz HT mesh STAs in a 20 MHz MBSS.

johannes

�{.n�+�������+%��lzwm��b�맲��r��zX��
"��^�ȧ���ܨ}���Ơz�&j:+v����n�r��6;靫3��\
nnX��f�z��2�ޙ���&�)ߡ�a����
�G���h��j:+v���w�٥
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help