[PATCH] brcmfmac: add missing break when deleting P2P_DEVICE

Subsystems: broadcom brcm80211 ieee802.11 wireless drivers, the rest

STALE3688d

2 messages, 2 authors, 2016-06-29 · open the first message on its own page

[PATCH] brcmfmac: add missing break when deleting P2P_DEVICE

From: Rafał Miłecki <zajec5@gmail.com>
Date: 2016-06-18 23:57:10

We obviously don't want to fall through in that switch. With this change
1) We wait for event (triggered by p2p_disc) as expected
2) We remove interface manually on timeout
3) We return 0 on success instead of -ENOTSUPP

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
index 426ff05..f6241fd 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
@@ -2261,6 +2261,8 @@ int brcmf_p2p_del_vif(struct wiphy *wiphy, struct wireless_dev *wdev)
 			return 0;
 		brcmf_p2p_cancel_remain_on_channel(vif->ifp);
 		brcmf_p2p_deinit_discovery(p2p);
+		break;
+
 	default:
 		return -ENOTSUPP;
 	}
-- 
1.8.4.5

Re: brcmfmac: add missing break when deleting P2P_DEVICE

From: Kalle Valo <hidden>
Date: 2016-06-29 16:02:14

Rafał Miłecki wrote:
We obviously don't want to fall through in that switch. With this change
1) We wait for event (triggered by p2p_disc) as expected
2) We remove interface manually on timeout
3) We return 0 on success instead of -ENOTSUPP

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Thanks, 1 patch applied to wireless-drivers-next.git:

20856adf2280 brcmfmac: add missing break when deleting P2P_DEVICE

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9185903/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help