[PATCH] wlcore: sdio: Fix crash on wlcore_probe_of when failing to parse/map irq

Subsystems: the rest, ti wilink wireless drivers

STALE3690d

2 messages, 2 authors, 2016-06-29 · open the first message on its own page

[PATCH] wlcore: sdio: Fix crash on wlcore_probe_of when failing to parse/map irq

From: Bruno Herrera <hidden>
Date: 2016-06-10 00:47:10

pdev_data pointer is being freed with kfree but the pointer is not dynamic allocated.

Signed-off-by: Bruno Herrera <redacted>
---
 drivers/net/wireless/ti/wlcore/sdio.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
index c172da5..5839acb 100644
--- a/drivers/net/wireless/ti/wlcore/sdio.c
+++ b/drivers/net/wireless/ti/wlcore/sdio.c
@@ -241,7 +241,6 @@ static int wlcore_probe_of(struct device *dev, int *irq,
 	*irq = irq_of_parse_and_map(np, 0);
 	if (!*irq) {
 		dev_err(dev, "No irq in platform data\n");
-		kfree(pdev_data);
 		return -EINVAL;
 	}
 
-- 
2.7.4 (Apple Git-66)

Re: wlcore: sdio: Fix crash on wlcore_probe_of when failing to parse/map irq

From: Kalle Valo <hidden>
Date: 2016-06-29 15:47:32

Bruno Herrera [off-list ref] wrote:
pdev_data pointer is being freed with kfree but the pointer is not dynamic allocated.

Signed-off-by: Bruno Herrera <redacted>
Thanks, 1 patch applied to wireless-drivers-next.git:

6edc119ed3b5 wlcore: sdio: Fix crash on wlcore_probe_of when failing to parse/map irq

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9168709/

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help