linux-4.7-rc2/drivers/net/fjes/fjes_main.c:1346]: (style) Redundant condition
From: David Binderman <hidden>
Date: 2016-06-07 09:46:44
Also in:
lkml
From: David Binderman <hidden>
Date: 2016-06-07 09:46:44
Also in:
lkml
Hello there,
linux-4.7-rc2/drivers/net/fjes/fjes_main.c:1346]: (style) Redundant
condition: !is_shared. 'is_shared && (!is_shared || !stop_req_done)'
is equivalent to 'is_shared && !stop_req_done'
Source code is
if ((!stop_req ||
(is_shared && (!is_shared || !stop_req_done))) &&
(is_shared || !unshare_watch || !unshare_reserve))
if ((!stop_req ||
(is_shared && !stop_req_done)) &&
(is_shared || !unshare_watch || !unshare_reserve))
Also in the same file:
[drivers/net/fjes/fjes_main.c:1321]: (style) Variable 'max_epid' is
assigned a value that is never used.
[drivers/net/fjes/fjes_main.c:1320]: (style) Variable 'my_epid' is
assigned a value that is never used.
These two might be candidates for deletion.
Regards
David Binderman