[PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced"

Subsystems: freescale imx / mxc fec driver, networking drivers, the rest

STALE3712d

4 messages, 4 authors, 2016-06-06 · open the first message on its own page

[PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced"

From: Colin King <hidden>
Date: 2016-06-04 19:01:20

From: Colin Ian King <redacted>

trivial fix to spelling mistake in pr_err message

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/freescale/fec_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 3c0255e..96bd210 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2427,13 +2427,13 @@ fec_enet_set_coalesce(struct net_device *ndev, struct ethtool_coalesce *ec)
 
 	cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr);
 	if (cycle > 0xFFFF) {
-		pr_err("Rx coalesed usec exceeed hardware limiation");
+		pr_err("Rx coalesced usec exceeed hardware limiation");
 		return -EINVAL;
 	}
 
 	cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr);
 	if (cycle > 0xFFFF) {
-		pr_err("Rx coalesed usec exceeed hardware limiation");
+		pr_err("Rx coalesced usec exceeed hardware limiation");
 		return -EINVAL;
 	}
 
-- 
2.8.1

Re: [PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced"

From: Augusto Mecking Caringi <hidden>
Date: 2016-06-04 19:43:11

On Sat, Jun 4, 2016 at 4:01 PM, Colin King [off-list ref] wrote:
quoted hunk
From: Colin Ian King <redacted>

trivial fix to spelling mistake in pr_err message

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/freescale/fec_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 3c0255e..96bd210 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2427,13 +2427,13 @@ fec_enet_set_coalesce(struct net_device *ndev, struct ethtool_coalesce *ec)

        cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr);
        if (cycle > 0xFFFF) {
-               pr_err("Rx coalesed usec exceeed hardware limiation");
+               pr_err("Rx coalesced usec exceeed hardware limiation");
                return -EINVAL;
        }

        cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr);
        if (cycle > 0xFFFF) {
-               pr_err("Rx coalesed usec exceeed hardware limiation");
+               pr_err("Rx coalesced usec exceeed hardware limiation");
                return -EINVAL;
        }
s/limiation/limitation

-- 
Augusto Mecking Caringi

Re: [PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced"

From: Joe Perches <joe@perches.com>
Date: 2016-06-05 06:36:41

On Sat, 2016-06-04 at 16:43 -0300, Augusto Mecking Caringi wrote:
On Sat, Jun 4, 2016 at 4:01 PM, Colin King [off-list ref] wrote:
quoted
From: Colin Ian King <redacted>
trivial fix to spelling mistake in pr_err message
[]
quoted
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
[]
quoted
@@ -2427,13 +2427,13 @@ fec_enet_set_coalesce(struct net_device *ndev, struct ethtool_coalesce *ec)
        cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr);
        if (cycle > 0xFFFF) {
-               pr_err("Rx coalesed usec exceeed hardware limiation");
+               pr_err("Rx coalesced usec exceeed hardware limiation");
                return -EINVAL;
        }

        cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr);
        if (cycle > 0xFFFF) {
-               pr_err("Rx coalesed usec exceeed hardware limiation");
+               pr_err("Rx coalesced usec exceeed hardware limiation");
                return -EINVAL;
        }
s/limiation/limitation
Could also add \n terminations to the pr_err uses.

RE: [PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced"

From: Fugang Duan <hidden>
Date: 2016-06-06 04:48:14

From: Colin King <redacted> Sent: Sunday, June 05, 2016 3:01 AM
quoted hunk
To: Fugang Duan <redacted>; netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced"

From: Colin Ian King <redacted>

trivial fix to spelling mistake in pr_err message

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/freescale/fec_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index 3c0255e..96bd210 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2427,13 +2427,13 @@ fec_enet_set_coalesce(struct net_device *ndev,
struct ethtool_coalesce *ec)

 	cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr);
 	if (cycle > 0xFFFF) {
-		pr_err("Rx coalesed usec exceeed hardware limiation");
+		pr_err("Rx coalesced usec exceeed hardware limiation");
coalesed -> coalesced, Exceeed -> exceed,  limitation-> limitation

So:
pr_err("Rx coalesced usec exceed hardware limitation \n");
 		return -EINVAL;
 	}

 	cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr);
 	if (cycle > 0xFFFF) {
-		pr_err("Rx coalesed usec exceeed hardware limiation");
+		pr_err("Rx coalesced usec exceeed hardware limiation");
pr_err("Rx coalesced usec exceed hardware limitation \n");

Of course, pls add "\n" terminate char for all pr_err() in . fec_enet_set_coalesce() function.
Thanks.
 		return -EINVAL;
 	}

--
2.8.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help