[PATCH] net: ethernet: ti: cpsw: remove unused priv lock

Subsystems: networking drivers, the rest, ti ethernet switch driver (cpsw)

STALE3714d

3 messages, 3 authors, 2016-06-03 · open the first message on its own page

[PATCH] net: ethernet: ti: cpsw: remove unused priv lock

From: Ivan Khoronzhuk <hidden>
Date: 2016-06-02 22:37:24

There is no reason in this lock. At least for now.

Signed-off-by: Ivan Khoronzhuk <redacted>
---

Based on master

 drivers/net/ethernet/ti/cpsw.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index 9919cb3..8d1d373 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -365,7 +365,6 @@ static inline void slave_write(struct cpsw_slave *slave, u32 val, u32 offset)
 }
 
 struct cpsw_priv {
-	spinlock_t			lock;
 	struct platform_device		*pdev;
 	struct net_device		*ndev;
 	struct napi_struct		napi_rx;
@@ -2413,7 +2412,6 @@ static int cpsw_probe_dual_emac(struct platform_device *pdev,
 	}
 
 	priv_sl2 = netdev_priv(ndev);
-	spin_lock_init(&priv_sl2->lock);
 	priv_sl2->data = *data;
 	priv_sl2->pdev = pdev;
 	priv_sl2->ndev = ndev;
@@ -2533,7 +2531,6 @@ static int cpsw_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, ndev);
 	priv = netdev_priv(ndev);
-	spin_lock_init(&priv->lock);
 	priv->pdev = pdev;
 	priv->ndev = ndev;
 	priv->dev  = &ndev->dev;
-- 
1.9.1

Re: [PATCH] net: ethernet: ti: cpsw: remove unused priv lock

From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: 2016-06-03 16:48:07

On 06/03/2016 01:37 AM, Ivan Khoronzhuk wrote:
quoted hunk
There is no reason in this lock. At least for now.

Signed-off-by: Ivan Khoronzhuk <redacted>
---

Based on master

  drivers/net/ethernet/ti/cpsw.c | 3 ---
  1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index 9919cb3..8d1d373 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -365,7 +365,6 @@ static inline void slave_write(struct cpsw_slave *slave, u32 val, u32 offset)
  }

  struct cpsw_priv {
-	spinlock_t			lock;
  	struct platform_device		*pdev;
  	struct net_device		*ndev;
  	struct napi_struct		napi_rx;
@@ -2413,7 +2412,6 @@ static int cpsw_probe_dual_emac(struct platform_device *pdev,
  	}

  	priv_sl2 = netdev_priv(ndev);
-	spin_lock_init(&priv_sl2->lock);
  	priv_sl2->data = *data;
  	priv_sl2->pdev = pdev;
  	priv_sl2->ndev = ndev;
@@ -2533,7 +2531,6 @@ static int cpsw_probe(struct platform_device *pdev)

  	platform_set_drvdata(pdev, ndev);
  	priv = netdev_priv(ndev);
-	spin_lock_init(&priv->lock);
  	priv->pdev = pdev;
  	priv->ndev = ndev;
  	priv->dev  = &ndev->dev;
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

-- 
regards,
-grygorii

Re: [PATCH] net: ethernet: ti: cpsw: remove unused priv lock

From: David Miller <davem@davemloft.net>
Date: 2016-06-03 23:44:01

From: Ivan Khoronzhuk <redacted>
Date: Fri,  3 Jun 2016 01:37:08 +0300
There is no reason in this lock. At least for now.

Signed-off-by: Ivan Khoronzhuk <redacted>
Applied to net-next.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help