# Re: \[PATCH 4/8\] mwifiex: consolidate mwifiex\_sdio\_probe() error paths

- From: Julian Calaby \<hidden\>
- Date: 2016-06-01 04:19:04 
- List: netdev
- Page: https://ratatoskr.run/netdev/2016/06/4761848
- Thread: https://ratatoskr.run/netdev/2016/05/4759065/t.md

```text
Hi All,

On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas
[ref] wrote:
> Instead of duplicating part of the cleanups needed in case of an error
> in .probe callback, have a single error path and use goto labels as is
> common practice in the kernel.
>
> This also has the nice side effect that the cleanup operations are made
> in the inverse order of their counterparts, which was not the case for
> the mwifiex_add_card() error path.
>
> Signed-off-by: Javier Martinez Canillas <redacted>

This looks sensible to me.

Reviewed-by: Julian Calaby <redacted>

> ---
>
>  drivers/net/wireless/marvell/mwifiex/sdio.c | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
```