# Re: \[PATCH 1/8\] mwifiex: only call mwifiex\_sdio\_probe\_of() if dev has an OF node

- From: Julian Calaby \<hidden\>
- Date: 2016-06-01 04:14:48 
- List: netdev
- Page: https://ratatoskr.run/netdev/2016/06/4761842
- Thread: https://ratatoskr.run/netdev/2016/05/4759065/t.md

```text
Hi All,

On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas
[ref] wrote:
> SDIO is an auto enumerable bus so the SDIO devices are matched using the
> sdio_device_id table and not using compatible strings from a OF id table.
>
> However, commit ce4f6f0c353b ("mwifiex: add platform specific wakeup
> interrupt support") allowed to match nodes defined as child of the SDIO
> host controller in the probe function using a compatible string to setup
> platform specific parameters in the DT.
>
> The problem is that the OF parse function is always called regardless if
> the SDIO dev has an OF node associated or not, and prints an error if it
> is not found. So, on a platform that doesn't have a node for a SDIO dev,
> the following misleading error message will be printed:
>
> [  12.480042] mwifiex_sdio mmc2:0001:1: sdio platform data not available
>
> Signed-off-by: Javier Martinez Canillas <redacted>

This looks sensible to me.

Reviewed-by: Julian Calaby <redacted>

>  drivers/net/wireless/marvell/mwifiex/sdio.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Thanks,

-- 
Julian Calaby

Email: julian.calaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
```