[patch] be2net: signedness bug in be_msix_enable()

Subsystems: emulex 10gbps nic be2, be3-r, lancer, skyhawk-r driver (be2net), networking drivers, the rest

STALE3695d

3 messages, 3 authors, 2016-06-30 · open the first message on its own page

[patch] be2net: signedness bug in be_msix_enable()

From: Dan Carpenter <hidden>
Date: 2016-06-29 14:39:43

"num_vec" needs to be signed for the error handling to work.

Fixes: e261768e9e39 ('be2net: support asymmetric rx/tx queue counts')
Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 1873c74..1f16e73 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -3251,8 +3251,9 @@ static void be_msix_disable(struct be_adapter *adapter)
 
 static int be_msix_enable(struct be_adapter *adapter)
 {
-	unsigned int i, num_vec, max_roce_eqs;
+	unsigned int i, max_roce_eqs;
 	struct device *dev = &adapter->pdev->dev;
+	int num_vec;
 
 	/* If RoCE is supported, program the max number of vectors that
 	 * could be used for NIC and RoCE, else, just program the number

RE: [patch] be2net: signedness bug in be_msix_enable()

From: Sathya Perla <hidden>
Date: 2016-06-30 11:22:56

quoted hunk
-----Original Message-----
From: Dan Carpenter [mailto:dan.carpenter@oracle.com]

"num_vec" needs to be signed for the error handling to work.

Fixes: e261768e9e39 ('be2net: support asymmetric rx/tx queue counts')
Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/emulex/benet/be_main.c
quoted hunk
index 1873c74..1f16e73 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -3251,8 +3251,9 @@ static void be_msix_disable(struct be_adapter
*adapter)
 static int be_msix_enable(struct be_adapter *adapter)  {
-	unsigned int i, num_vec, max_roce_eqs;
+	unsigned int i, max_roce_eqs;
 	struct device *dev = &adapter->pdev->dev;
+	int num_vec;
Oops...thanks for catching this! This must go into net-next.

Acked-by: Sathya Perla <redacted>

Re: [patch] be2net: signedness bug in be_msix_enable()

From: David Miller <davem@davemloft.net>
Date: 2016-06-30 12:56:56

From: Dan Carpenter <redacted>
Date: Wed, 29 Jun 2016 17:39:43 +0300
"num_vec" needs to be signed for the error handling to work.

Fixes: e261768e9e39 ('be2net: support asymmetric rx/tx queue counts')
Signed-off-by: Dan Carpenter <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help