[PATCH net] ipv4: fix checksum annotation in udp4_csum_init

Subsystems: networking [general], the rest, user datagram protocol (udp)

STALE3716d

2 messages, 2 authors, 2016-06-14 · open the first message on its own page

[PATCH net] ipv4: fix checksum annotation in udp4_csum_init

From: Hannes Frederic Sowa <hidden>
Date: 2016-06-12 10:02:56

Reported-by: Cong Wang <redacted>
Cc: Cong Wang <redacted>
Cc: Tom Herbert <redacted>
Fixes: 4068579e1e098fa ("net: Implmement RFC 6936 (zero RX csums for UDP/IPv6")
Signed-off-by: Hannes Frederic Sowa <redacted>
---
 net/ipv4/udp.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index 0ff31d97d48586..ba0d8b8b76900a 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -1755,8 +1755,11 @@ static inline int udp4_csum_init(struct sk_buff *skb, struct udphdr *uh,
 			return err;
 	}
 
-	return skb_checksum_init_zero_check(skb, proto, uh->check,
-					    inet_compute_pseudo);
+	/* Note, we are only interested in != 0 or == 0, thus the
+	 * force to int.
+	 */
+	return (__force int)skb_checksum_init_zero_check(skb, proto, uh->check,
+							 inet_compute_pseudo);
 }
 
 /*
-- 
2.5.5

Re: [PATCH net] ipv4: fix checksum annotation in udp4_csum_init

From: David Miller <davem@davemloft.net>
Date: 2016-06-14 19:28:45

From: Hannes Frederic Sowa <redacted>
Date: Sun, 12 Jun 2016 12:02:46 +0200
Reported-by: Cong Wang <redacted>
Cc: Cong Wang <redacted>
Cc: Tom Herbert <redacted>
Fixes: 4068579e1e098fa ("net: Implmement RFC 6936 (zero RX csums for UDP/IPv6")
Signed-off-by: Hannes Frederic Sowa <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help