[PATCH net] ipv6: fix endianness error in icmpv6_err

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE3704d

3 messages, 3 authors, 2016-06-14 · open the first message on its own page

[PATCH net] ipv6: fix endianness error in icmpv6_err

From: Hannes Frederic Sowa <hidden>
Date: 2016-06-11 18:32:46

IPv6 ping socket error handler doesn't correctly convert the new 32 bit
mtu to host endianness before using.

Cc: Lorenzo Colitti <redacted>
Fixes: 6d0bfe22611602f ("net: ipv6: Add IPv6 support to the ping socket.")
Signed-off-by: Hannes Frederic Sowa <redacted>
---
 net/ipv6/icmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c
index 4527285fcaa2c2..a4fa840769690a 100644
--- a/net/ipv6/icmp.c
+++ b/net/ipv6/icmp.c
@@ -98,7 +98,7 @@ static void icmpv6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
 
 	if (!(type & ICMPV6_INFOMSG_MASK))
 		if (icmp6->icmp6_type == ICMPV6_ECHO_REQUEST)
-			ping_err(skb, offset, info);
+			ping_err(skb, offset, ntohl(info));
 }
 
 static int icmpv6_rcv(struct sk_buff *skb);
-- 
2.5.5

Re: [PATCH net] ipv6: fix endianness error in icmpv6_err

From: Lorenzo Colitti <hidden>
Date: 2016-06-12 03:38:51

On Sun, Jun 12, 2016 at 3:32 AM, Hannes Frederic Sowa
[off-list ref] wrote:
IPv6 ping socket error handler doesn't correctly convert the new 32 bit
mtu to host endianness before using.
...
        if (!(type & ICMPV6_INFOMSG_MASK))
                if (icmp6->icmp6_type == ICMPV6_ECHO_REQUEST)
-                       ping_err(skb, offset, info);
+                       ping_err(skb, offset, ntohl(info));
 }
Acked-by: Lorenzo Colitti <redacted>

Re: [PATCH net] ipv6: fix endianness error in icmpv6_err

From: David Miller <davem@davemloft.net>
Date: 2016-06-14 19:25:09

From: Hannes Frederic Sowa <redacted>
Date: Sat, 11 Jun 2016 20:32:06 +0200
IPv6 ping socket error handler doesn't correctly convert the new 32 bit
mtu to host endianness before using.

Cc: Lorenzo Colitti <redacted>
Fixes: 6d0bfe22611602f ("net: ipv6: Add IPv6 support to the ping socket.")
Signed-off-by: Hannes Frederic Sowa <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help