[PATCH] [V3] net: ipconfig: avoid warning by making ic_addrservaddr static

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE3711d

2 messages, 2 authors, 2016-06-11 · open the first message on its own page

[PATCH] [V3] net: ipconfig: avoid warning by making ic_addrservaddr static

From: Ben Dooks <hidden>
Date: 2016-06-10 11:12:14

The symbol ic_addrservaddr is not static, but has no declaration
to match so make it static to fix the following warning:

net/ipv4/ipconfig.c:130:8: warning: symbol 'ic_addrservaddr' was not declared. Should it be static?

Signed-off-by: Ben Dooks <redacted>
---
V3: fix the title from V2
V2: make ic_addrservaddr static instead of adding to header
---
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Alexey Kuznetsov <redacted>
Cc: James Morris <jmorris@namei.org>
Cc: Hideaki YOSHIFUJI <redacted>
Cc: Patrick McHardy <redacted>
Cc: netdev@vger.kernel.org
---
 net/ipv4/ipconfig.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 2ed9dd2..eccf9fd 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -127,7 +127,7 @@ __be32 ic_myaddr = NONE;		/* My IP address */
 static __be32 ic_netmask = NONE;	/* Netmask for local subnet */
 __be32 ic_gateway = NONE;	/* Gateway IP address */
 
-__be32 ic_addrservaddr = NONE;	/* IP Address of the IP addresses'server */
+static __be32 ic_addrservaddr = NONE;	/* IP Address of the IP addresses'server */
 
 __be32 ic_servaddr = NONE;	/* Boot server IP address */
 
-- 
2.8.1

Re: [PATCH] [V3] net: ipconfig: avoid warning by making ic_addrservaddr static

From: David Miller <davem@davemloft.net>
Date: 2016-06-11 06:28:29

From: Ben Dooks <redacted>
Date: Fri, 10 Jun 2016 12:11:06 +0100
The symbol ic_addrservaddr is not static, but has no declaration
to match so make it static to fix the following warning:

net/ipv4/ipconfig.c:130:8: warning: symbol 'ic_addrservaddr' was not declared. Should it be static?

Signed-off-by: Ben Dooks <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help