[PATCH] macvtap: fix bugon.cocci warnings

STALE3710d

3 messages, 2 authors, 2016-06-08 · open the first message on its own page

[PATCH] macvtap: fix bugon.cocci warnings

From: Julia Lawall <hidden>
Date: 2016-06-08 16:15:34

 Use BUG_ON instead of a if condition followed by BUG.

Generated by: scripts/coccinelle/misc/bugon.cocci

CC: Mike Rapoport <redacted>
Signed-off-by: Julia Lawall <redacted>
Signed-off-by: Fengguang Wu <redacted>
---

 macvtap.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -796,8 +796,7 @@ static ssize_t macvtap_put_user(struct m

 		ret = virtio_net_hdr_from_skb(skb, &vnet_hdr,
 					      macvtap_is_little_endian(q));
-		if (ret)
-			BUG();
+		BUG_ON(ret);

 		if (copy_to_iter(&vnet_hdr, sizeof(vnet_hdr), iter) !=
 		    sizeof(vnet_hdr))

Re: [PATCH] macvtap: fix bugon.cocci warnings

From: David Miller <davem@davemloft.net>
Date: 2016-06-08 18:30:26

From: Julia Lawall <redacted>
Date: Wed, 8 Jun 2016 18:15:29 +0200 (CEST)
 Use BUG_ON instead of a if condition followed by BUG.

Generated by: scripts/coccinelle/misc/bugon.cocci

CC: Mike Rapoport <redacted>
Signed-off-by: Julia Lawall <redacted>
Signed-off-by: Fengguang Wu <redacted>
This doesn't apply cleanly to any of my trees.

Re: [PATCH] macvtap: fix bugon.cocci warnings

From: Julia Lawall <hidden>
Date: 2016-06-08 20:59:16


On Wed, 8 Jun 2016, David Miller wrote:
From: Julia Lawall <redacted>
Date: Wed, 8 Jun 2016 18:15:29 +0200 (CEST)
quoted
 Use BUG_ON instead of a if condition followed by BUG.

Generated by: scripts/coccinelle/misc/bugon.cocci

CC: Mike Rapoport <redacted>
Signed-off-by: Julia Lawall <redacted>
Signed-off-by: Fengguang Wu <redacted>
This doesn't apply cleanly to any of my trees.
Sorry not to have included the source information.  It seems to be from 
here:

https://github.com/0day-ci/linux/commits/Mike-Rapoport/virtio_net-add-_UAPI-prefix-to-virtio_net-header-guards/20160608-211558

julia
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help