[PATCH net-next] net: Reduce queue allocation to one in kdump kernel

Subsystems: networking [general], the rest

STALE3744d

3 messages, 3 authors, 2016-06-09 · open the first message on its own page

[PATCH net-next] net: Reduce queue allocation to one in kdump kernel

From: Hariprasad Shenai <hidden>
Date: 2016-06-08 12:33:57

When in kdump kernel, reduce memory usage by only using a single Queue
Set for multiqueue devices. So make netif_get_num_default_rss_queues()
return one, when in kdump kernel.

Signed-off-by: Hariprasad Shenai <redacted>
---
 net/core/dev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 904ff431d570..161c4627a798 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c

@@ -139,6 +139,7 @@
 #include <linux/hrtimer.h>
 #include <linux/netfilter_ingress.h>
 #include <linux/sctp.h>
+#include <linux/crash_dump.h>
 
 #include "net-sysfs.h"

@@ -2249,7 +2250,8 @@ EXPORT_SYMBOL(netif_set_real_num_rx_queues);
  */
 int netif_get_num_default_rss_queues(void)
 {
-	return min_t(int, DEFAULT_MAX_NUM_RSS_QUEUES, num_online_cpus());
+	return is_kdump_kernel() ?
+		1 : min_t(int, DEFAULT_MAX_NUM_RSS_QUEUES, num_online_cpus());
 }
 EXPORT_SYMBOL(netif_get_num_default_rss_queues);

-- 
2.3.4

Re: [PATCH net-next] net: Reduce queue allocation to one in kdump kernel

From: David Miller <davem@davemloft.net>
Date: 2016-06-08 18:14:28

From: Hariprasad Shenai <redacted>
Date: Wed,  8 Jun 2016 18:09:08 +0530

When in kdump kernel, reduce memory usage by only using a single Queue
Set for multiqueue devices. So make netif_get_num_default_rss_queues()
return one, when in kdump kernel.

Signed-off-by: Hariprasad Shenai <redacted>

Applied, thanks.

Re: [PATCH net-next] net: Reduce queue allocation to one in kdump kernel

From: Cong Wang <hidden>
Date: 2016-06-09 22:06:44

On Wed, Jun 8, 2016 at 5:39 AM, Hariprasad Shenai
[off-list ref] wrote:

quoted hunk

When in kdump kernel, reduce memory usage by only using a single Queue
Set for multiqueue devices. So make netif_get_num_default_rss_queues()
return one, when in kdump kernel.

Signed-off-by: Hariprasad Shenai <redacted>
---
 net/core/dev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 904ff431d570..161c4627a798 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c

@@ -139,6 +139,7 @@
 #include <linux/hrtimer.h>
 #include <linux/netfilter_ingress.h>
 #include <linux/sctp.h>
+#include <linux/crash_dump.h>

 #include "net-sysfs.h"

@@ -2249,7 +2250,8 @@ EXPORT_SYMBOL(netif_set_real_num_rx_queues);
  */
 int netif_get_num_default_rss_queues(void)
 {
-       return min_t(int, DEFAULT_MAX_NUM_RSS_QUEUES, num_online_cpus());
+       return is_kdump_kernel() ?
+               1 : min_t(int, DEFAULT_MAX_NUM_RSS_QUEUES, num_online_cpus());

IIRC, kdump kernel already uses cpus=1, or at least you can tell how many
CPU's you want in kdump config.

This change doesn't make any sense to me, we don't want to check
for kdump for every of such places, do we?

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help