pull-request: can 2016-03-04

3 messages, 2 authors, 2016-03-04 · open the first message on its own page

pull-request: can 2016-03-04

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2016-03-04 07:56:04

Hello David,

this is a pull request for net/master.

There is one patch from Ed Spiridonov, which increases the performance of the
mcp251x SPI CAN driver, by avoiding to write to error flag register if it's
unnecessary.

regards,
Marc

---

The following changes since commit c1bb0a5588816ec26abc08aa9adcf90e32656781:

  be2net: don't enable multicast flag in be_enable_if_filters() routine (2016-03-03 17:18:03 -0500)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-4.5-20160304

for you to fetch changes up to d694b06c42a56c9610861ee0474b4d441af8ada6:

  can: mcp251x: avoid write to error flag register if it's unnecessary (2016-03-04 08:45:17 +0100)

----------------------------------------------------------------
linux-can-fixes-for-4.5-20160304

----------------------------------------------------------------
Ed Spiridonov (1):
      can: mcp251x: avoid write to error flag register if it's unnecessary

 drivers/net/can/spi/mcp251x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] can: mcp251x: avoid write to error flag register if it's unnecessary

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2016-03-04 07:55:55

From: Ed Spiridonov <redacted>

Only two bits (RX0OVR and RX1OVR) are writable in EFLG, write is useless
if these bits aren't set.

Signed-off-by: Ed Spiridonov <redacted>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 drivers/net/can/spi/mcp251x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c
index 575790e8a75a..74a7dfecee27 100644
--- a/drivers/net/can/spi/mcp251x.c
+++ b/drivers/net/can/spi/mcp251x.c
@@ -843,7 +843,7 @@ static irqreturn_t mcp251x_can_ist(int irq, void *dev_id)
 		if (clear_intf)
 			mcp251x_write_bits(spi, CANINTF, clear_intf, 0x00);
 
-		if (eflag)
+		if (eflag & (EFLG_RX0OVR | EFLG_RX1OVR))
 			mcp251x_write_bits(spi, EFLG, eflag, 0x00);
 
 		/* Update can state */
-- 
2.7.0

Re: pull-request: can 2016-03-04

From: David Miller <davem@davemloft.net>
Date: 2016-03-04 19:33:37

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Fri,  4 Mar 2016 08:55:54 +0100
Hello David,

this is a pull request for net/master.

There is one patch from Ed Spiridonov, which increases the performance of the
mcp251x SPI CAN driver, by avoiding to write to error flag register if it's
unnecessary.
Pulled, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help