Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

6 messages, 4 authors, 2016-03-11 · open the first message on its own page

Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

From: Andreas Färber <afaerber@suse.de>
Date: 2016-03-07 12:17:54

Am 06.03.2016 um 20:53 schrieb Andreas Färber:
On next-20160304 the GMAC seems to have regressed, it no longer finds the PHY:

libphy: PHY stmmac-0:ffffffff not found
eth0: Could not attach to PHY
stmmac_open: Cannot attach to PHY (error: -19)
Still with us in next-20160307. CC'ing stmmac maintainers.

http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/drivers/net/ethernet/stmicro

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

From: Heiko Stübner <heiko@sntech.de>
Date: 2016-03-07 12:24:25

Hi Andreas,

Am Montag, 7. März 2016, 13:17:54 schrieb Andreas Färber:
Am 06.03.2016 um 20:53 schrieb Andreas Färber:
quoted
On next-20160304 the GMAC seems to have regressed, it no longer finds the
PHY:

libphy: PHY stmmac-0:ffffffff not found
eth0: Could not attach to PHY
stmmac_open: Cannot attach to PHY (error: -19)
Still with us in next-20160307. CC'ing stmmac maintainers.
do you remember from what revision you rebased away from, when it was still 
working (as a known-good state)?


Heiko
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/drivers/
net/ethernet/stmicro

Regards,
Andreas

Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

From: Andreas Färber <afaerber@suse.de>
Date: 2016-03-07 12:35:31

Hi Heiko,

Am 07.03.2016 um 13:24 schrieb Heiko Stübner:
Am Montag, 7. März 2016, 13:17:54 schrieb Andreas Färber:
quoted
Am 06.03.2016 um 20:53 schrieb Andreas Färber:
quoted
On next-20160304 the GMAC seems to have regressed, it no longer finds the
PHY:

libphy: PHY stmmac-0:ffffffff not found
eth0: Could not attach to PHY
stmmac_open: Cannot attach to PHY (error: -19)
Still with us in next-20160307. CC'ing stmmac maintainers.
do you remember from what revision you rebased away from, when it was still 
working (as a known-good state)?
Hm, next-20160111 possibly... leaving all the 5 days and 4 days ago
changes as candidates ("stmmac: share reset function between dwmac100
and dwmac1000" .. "stmmac: Fix 'eth0: No PHY found' regression").

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

From: Giuseppe CAVALLARO <hidden>
Date: 2016-03-07 13:26:14

Hello Andreas, Heiko,

On 3/7/2016 1:35 PM, Andreas Färber wrote:
Hi Heiko,

Am 07.03.2016 um 13:24 schrieb Heiko Stübner:
quoted
Am Montag, 7. März 2016, 13:17:54 schrieb Andreas Färber:
quoted
Am 06.03.2016 um 20:53 schrieb Andreas Färber:
quoted
On next-20160304 the GMAC seems to have regressed, it no longer finds the
PHY:

libphy: PHY stmmac-0:ffffffff not found
snps,phy-addr is not correct. Can you check it?

In the stmmac_mdio if this is not passed as parameter the bus should
be scanned and the first IDs found should select the right address.
I suppose in your box there is a real transceiver, so maybe the patch
from Gabriel is not actually necessary.
quoted
quoted
quoted
eth0: Could not attach to PHY
stmmac_open: Cannot attach to PHY (error: -19)
Still with us in next-20160307. CC'ing stmmac maintainers.
peppe
quoted
do you remember from what revision you rebased away from, when it was still
working (as a known-good state)?
Hm, next-20160111 possibly... leaving all the 5 days and 4 days ago
changes as candidates ("stmmac: share reset function between dwmac100
and dwmac1000" .. "stmmac: Fix 'eth0: No PHY found' regression").

Regards,
Andreas

Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

From: Andreas Färber <afaerber@suse.de>
Date: 2016-03-07 14:27:10

Hello Giuseppe,

Am 07.03.2016 um 14:26 schrieb Giuseppe CAVALLARO:
On 3/7/2016 1:35 PM, Andreas Färber wrote:
quoted
Am 07.03.2016 um 13:24 schrieb Heiko Stübner:
quoted
Am Montag, 7. März 2016, 13:17:54 schrieb Andreas Färber:
quoted
Am 06.03.2016 um 20:53 schrieb Andreas Färber:
quoted
On next-20160304 the GMAC seems to have regressed, it no longer
finds the
PHY:

libphy: PHY stmmac-0:ffffffff not found
snps,phy-addr is not correct. Can you check it?
It was never set:

https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/rockchip/rk3368.dtsi#n436

https://github.com/afaerber/linux/blob/96c5b5fd395fee5713755e93e677fb011cb9ddc0/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts#L114
In the stmmac_mdio if this is not passed as parameter the bus should
be scanned and the first IDs found should select the right address.
I suppose in your box there is a real transceiver, so maybe the patch
from Gabriel is not actually necessary.
On the GeekBox module there's an RTL8211E phy.

Indeed, reverting Gabriel's commit fixes the observed error messages:

rk_gmac-dwmac ff290000.ethernet eth0: Link is Up - 1Gbps/Full - flow
control rx/tx

http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/net/ethernet/stmicro?id=88f8b1bb41c6208f81b6a480244533ded7b59493

However, I am unable to ping any hosts on the network now.

Regards,
Andreas
quoted
quoted
quoted
quoted
eth0: Could not attach to PHY
stmmac_open: Cannot attach to PHY (error: -19)
Still with us in next-20160307. CC'ing stmmac maintainers.
peppe
quoted
quoted
do you remember from what revision you rebased away from, when it was
still
working (as a known-good state)?
Hm, next-20160111 possibly... leaving all the 5 days and 4 days ago
changes as candidates ("stmmac: share reset function between dwmac100
and dwmac1000" .. "stmmac: Fix 'eth0: No PHY found' regression").
-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

From: Michael Trimarchi <michael@amarulasolutions.com>
Date: 2016-03-11 12:12:03

Hi

On Mon, Mar 7, 2016 at 1:17 PM, Andreas Färber [off-list ref] wrote:
Am 06.03.2016 um 20:53 schrieb Andreas Färber:
quoted
On next-20160304 the GMAC seems to have regressed, it no longer finds the PHY:

libphy: PHY stmmac-0:ffffffff not found
eth0: Could not attach to PHY
stmmac_open: Cannot attach to PHY (error: -19)
Still with us in next-20160307. CC'ing stmmac maintainers.
        tx_delay = <0x30>;
        rx_delay = <0x10>;
        status = "ok";
+       mdio0 {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "snps,dwmac-mdio";
+               ethphy0: ethernet-phy@0 {
+               };
+       };

This is sufficient to get it in the rk3288 firefly

git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next

Michael
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/drivers/net/ethernet/stmicro

Regards,
Andreas

--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip


-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help