[PATCH] qed: initialize return rc to avoid returning garbage

Subsystems: networking drivers, qlogic ql4xxx ethernet driver, the rest

STALE3815d

3 messages, 3 authors, 2016-03-30 · open the first message on its own page

[PATCH] qed: initialize return rc to avoid returning garbage

From: Colin King <hidden>
Date: 2016-03-29 17:00:55

From: Colin Ian King <redacted>

in the case where qed_slowpath_irq_req is not called, rc is not
assigned and so qed_int_igu_enable will return a garbage value.
Fix this by initializing rc to 0.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/qlogic/qed/qed_int.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c b/drivers/net/ethernet/qlogic/qed/qed_int.c
index ffd0acc..2017b01 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_int.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_int.c
@@ -2750,7 +2750,7 @@ void qed_int_igu_enable_int(struct qed_hwfn *p_hwfn,
 int qed_int_igu_enable(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt,
 		       enum qed_int_mode int_mode)
 {
-	int rc;
+	int rc = 0;
 
 	/* Configure AEU signal change to produce attentions */
 	qed_wr(p_hwfn, p_ptt, IGU_REG_ATTENTION_ENABLE, 0);
-- 
2.7.4

RE: [PATCH] qed: initialize return rc to avoid returning garbage

From: Yuval Mintz <hidden>
Date: 2016-03-29 18:43:29

From: Colin Ian King <redacted>

in the case where qed_slowpath_irq_req is not called, rc is not assigned and so
qed_int_igu_enable will return a garbage value.
Fix this by initializing rc to 0.

Signed-off-by: Colin Ian King <redacted>
Thanks Colin.
Acked-by: Yuval Mintz <redacted>

Re: [PATCH] qed: initialize return rc to avoid returning garbage

From: David Miller <davem@davemloft.net>
Date: 2016-03-30 19:48:45

From: Colin King <redacted>
Date: Tue, 29 Mar 2016 18:00:50 +0100
From: Colin Ian King <redacted>

in the case where qed_slowpath_irq_req is not called, rc is not
assigned and so qed_int_igu_enable will return a garbage value.
Fix this by initializing rc to 0.

Signed-off-by: Colin Ian King <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help