[PATCH] brcmfmac: sdio: remove unused variable retry_limit

Subsystems: broadcom brcm80211 ieee802.11 wireless drivers, the rest

STALE3823d

3 messages, 3 authors, 2016-04-06 · open the first message on its own page

[PATCH] brcmfmac: sdio: remove unused variable retry_limit

From: Colin King <hidden>
Date: 2016-03-20 17:35:08

From: Colin Ian King <redacted>

retry_limit has never been used during the life of this driver, so
we may as well remove it as it is redundant.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index 43fd3f4..cd92ba7 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
@@ -535,9 +535,6 @@ static int qcount[NUMPRIO];
 
 #define RETRYCHAN(chan) ((chan) == SDPCM_EVENT_CHANNEL)
 
-/* Retry count for register access failures */
-static const uint retry_limit = 2;
-
 /* Limit on rounding up frames */
 static const uint max_roundup = 512;
 
-- 
2.7.3

Re: [PATCH] brcmfmac: sdio: remove unused variable retry_limit

From: Julian Calaby <hidden>
Date: 2016-03-28 04:16:29

Hi All,

On Mon, Mar 21, 2016 at 4:34 AM, Colin King [off-list ref] wrote:
From: Colin Ian King <redacted>

retry_limit has never been used during the life of this driver, so
we may as well remove it as it is redundant.

Signed-off-by: Colin Ian King <redacted>
Looks right to me.

Reviewed-by: Julian Calaby <redacted>

quoted hunk
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index 43fd3f4..cd92ba7 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
@@ -535,9 +535,6 @@ static int qcount[NUMPRIO];

 #define RETRYCHAN(chan) ((chan) == SDPCM_EVENT_CHANNEL)

-/* Retry count for register access failures */
-static const uint retry_limit = 2;
-
 /* Limit on rounding up frames */
 static const uint max_roundup = 512;

--
2.7.3

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

Re: brcmfmac: sdio: remove unused variable retry_limit

From: Kalle Valo <hidden>
Date: 2016-04-06 18:43:06

From: Colin Ian King <redacted>

retry_limit has never been used during the life of this driver, so
we may as well remove it as it is redundant.

Signed-off-by: Colin Ian King <redacted>
Reviewed-by: Julian Calaby <redacted>
Thanks, applied to wireless-drivers-next.git.

Kalle Valo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help