From: Krzysztof Kozlowski <hidden> Date: 2016-03-03 08:04:47
The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet
direct dependencies.
Signed-off-by: Krzysztof Kozlowski <redacted>
---
drivers/irqchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
On Thursday 03 March 2016 17:03:30 Krzysztof Kozlowski wrote:
config ST_IRQCHIP
bool
select REGMAP
+ depends on HAS_IOMEM # For MFD_SYSCON
select MFD_SYSCON
help
Enables SysCfg Controlled IRQs on STi based platforms.
On Thursday 03 March 2016 17:03:30 Krzysztof Kozlowski wrote:
quoted
config ST_IRQCHIP
bool
select REGMAP
+ depends on HAS_IOMEM # For MFD_SYSCON
select MFD_SYSCON
help
Enables SysCfg Controlled IRQs on STi based platforms.
Not user visible.
Hmmm... you are right (here and in other patches) but why am I getting
all these errors:
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X
&& DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI &&
TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE &&
S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK &&
RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM
&& ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which
has unmet direct dependencies (HAS_IOMEM)
?
(ARCH=um, allyesconfig)
Adding depends here (and in other places) really helps... but it
should not have any impact...
Thanks for comments,
Krzysztof
On Thursday 03 March 2016 21:00:57 Krzysztof Kozlowski wrote:
quoted
Not user visible.
Hmmm... you are right (here and in other patches) but why am I getting
all these errors:
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X
&& DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI &&
TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE &&
S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK &&
RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM
&& ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which
has unmet direct dependencies (HAS_IOMEM)
?
(ARCH=um, allyesconfig)
The problem is that Kconfig will just print any option that
selects the one that has a missing dependency, but doesn't
show which of those are actually enabled.
Adding depends here (and in other places) really helps... but it
should not have any impact...
I think patch 5 by itself would have been sufficient.
Arnd
On Thursday 03 March 2016 21:00:57 Krzysztof Kozlowski wrote:
quoted
quoted
Not user visible.
Hmmm... you are right (here and in other patches) but why am I getting
all these errors:
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X
&& DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI &&
TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE &&
S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK &&
RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM
&& ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which
has unmet direct dependencies (HAS_IOMEM)
?
(ARCH=um, allyesconfig)
The problem is that Kconfig will just print any option that
selects the one that has a missing dependency, but doesn't
show which of those are actually enabled.
Indeed... but apparently putting direct HAS_IOMEM dependency on these
symbols silences the Kconfig warning.
quoted
Adding depends here (and in other places) really helps... but it
should not have any impact...
I think patch 5 by itself would have been sufficient.
Thanks for analysis. Since all patches are independent (and IMHO the
last one is not needed really) so I won't resend the patchset. Instead
let maintainer pick what is meaningful.
Best regards,
Krzysztof