[PATCH net] rtnl: fix msg size calculation in if_nlmsg_size()

Subsystems: networking [general], the rest

STALE3814d

3 messages, 3 authors, 2016-03-31 · open the first message on its own page

[PATCH net] rtnl: fix msg size calculation in if_nlmsg_size()

From: Nicolas Dichtel <hidden>
Date: 2016-03-31 16:11:16

Size of the attribute IFLA_PHYS_PORT_NAME was missing.

Fixes: db24a9044ee1 ("net: add support for phys_port_name")
CC: David Ahern <redacted>
Signed-off-by: Nicolas Dichtel <redacted>
---
 net/core/rtnetlink.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index f2066772d0f3..a75f7e94b445 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -909,6 +909,7 @@ static noinline size_t if_nlmsg_size(const struct net_device *dev,
 	       + rtnl_link_get_af_size(dev, ext_filter_mask) /* IFLA_AF_SPEC */
 	       + nla_total_size(MAX_PHYS_ITEM_ID_LEN) /* IFLA_PHYS_PORT_ID */
 	       + nla_total_size(MAX_PHYS_ITEM_ID_LEN) /* IFLA_PHYS_SWITCH_ID */
+	       + nla_total_size(IFNAMSIZ) /* IFLA_PHYS_PORT_NAME */
 	       + nla_total_size(1); /* IFLA_PROTO_DOWN */
 
 }
-- 
2.4.2

Re: [PATCH net] rtnl: fix msg size calculation in if_nlmsg_size()

From: David Ahern <hidden>
Date: 2016-03-31 16:13:55

On 3/31/16 10:10 AM, Nicolas Dichtel wrote:
Size of the attribute IFLA_PHYS_PORT_NAME was missing.

Fixes: db24a9044ee1 ("net: add support for phys_port_name")
CC: David Ahern <redacted>
Signed-off-by: Nicolas Dichtel <redacted>
---
  net/core/rtnetlink.c | 1 +
  1 file changed, 1 insertion(+)
Acked-by: David Ahern <redacted>

Re: [PATCH net] rtnl: fix msg size calculation in if_nlmsg_size()

From: David Miller <davem@davemloft.net>
Date: 2016-03-31 20:50:47

From: Nicolas Dichtel <redacted>
Date: Thu, 31 Mar 2016 18:10:31 +0200
Size of the attribute IFLA_PHYS_PORT_NAME was missing.

Fixes: db24a9044ee1 ("net: add support for phys_port_name")
CC: David Ahern <redacted>
Signed-off-by: Nicolas Dichtel <redacted>
Applied, and queued up for -stable, thanks Nicolas.

Man... this thing is getting really huge and unwieldly.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help