# Re: \[PATCH net-next 1/3\] perf: generalize perf\_callchain

- From: Peter Zijlstra \<peterz@infradead.org\>
- Date: 2016-02-25 16:45:52 
- List: netdev
- Page: https://ratatoskr.run/netdev/2016/02/4694448
- Thread: https://ratatoskr.run/netdev/2016/02/4688185/t.md

```text
On Thu, Feb 25, 2016 at 08:37:34AM -0800, Alexei Starovoitov wrote:
> On 2/25/16 6:18 AM, Peter Zijlstra wrote:
> >On Wed, Feb 17, 2016 at 07:58:57PM -0800, Alexei Starovoitov wrote:
> >>. avoid walking the stack when there is no room left in the buffer
> >>. generalize get_perf_callchain() to be called from bpf helper
> >
> >If it does two things it should be two patches.
> 
> could have been two patches, but it will only add more churn
> to the same lines. what's the concern?

It makes review easier, shows which modification is for what purpose.

Also the changelog really needs more; it should for example explain what
BPF needs from the callchain code, and preferably why.
```
