# Re: \[PATCH net-next 2/3\] bpf: introduce BPF\_MAP\_TYPE\_STACK\_TRACE

- From: Alexei Starovoitov \<hidden\>
- Date: 2016-02-25 16:43:53 
- List: netdev
- Page: https://ratatoskr.run/netdev/2016/02/4694446
- Thread: https://ratatoskr.run/netdev/2016/02/4688185/t.md

```text
On 2/25/16 6:23 AM, Peter Zijlstra wrote:
>> +	id = hash & (smap->n_buckets - 1);
> Its not at all clear where the corresponding rcu_read_lock() is at.
>
>> >+	bucket = rcu_dereference(smap->buckets[id]);

bpf programs of all types are always executing under rcu_read_lock().
This is fundamental for maps and majority of the helpers
that's why there is no WARN_ON(rcu_read_lock_held) in this helper,
since we already have it in many other places.
The rcu_read_lock() for kprobe type is in trace_call_bpf().
```
