[PATCH 1/2] net: qca_spi: Don't clear IFF_BROADCAST

Subsystems: networking drivers, qualcomm atheros qca7k ethernet driver, the rest

STALE3817d

4 messages, 2 authors, 2016-02-25 · open the first message on its own page

[PATCH 1/2] net: qca_spi: Don't clear IFF_BROADCAST

From: Stefan Wahren <hidden>
Date: 2016-02-23 19:23:59 

Currently qcaspi_netdev_setup accidentally clears IFF_BROADCAST.
So fix this by keeping the flags from ether_setup.

Reported-by: Michael Heimpold <redacted>
Signed-off-by: Stefan Wahren <redacted>
Fixes: 291ab06ecf67 (net: qualcomm: new Ethernet over SPI driver for QCA7000)
---
 drivers/net/ethernet/qualcomm/qca_spi.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c
index 689a4a5..f2ee3e5f 100644
--- a/drivers/net/ethernet/qualcomm/qca_spi.c
+++ b/drivers/net/ethernet/qualcomm/qca_spi.c
@@ -811,7 +811,6 @@ qcaspi_netdev_setup(struct net_device *dev)
 	dev->netdev_ops = &qcaspi_netdev_ops;
 	qcaspi_set_ethtool_ops(dev);
 	dev->watchdog_timeo = QCASPI_TX_TIMEOUT;
-	dev->flags = IFF_MULTICAST;
 	dev->tx_queue_len = 100;
 
 	qca = netdev_priv(dev);
-- 
1.7.9.5

[PATCH 2/2] net: qca_spi: clear IFF_TX_SKB_SHARING

From: Stefan Wahren <hidden>
Date: 2016-02-23 19:23:57 

ether_setup sets IFF_TX_SKB_SHARING but this is not supported by
qca_spi as it modifies the skb on xmit.

Signed-off-by: Stefan Wahren <redacted>
Fixes: 291ab06ecf67 (net: qualcomm: new Ethernet over SPI driver for QCA7000)
---
 drivers/net/ethernet/qualcomm/qca_spi.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c
index f2ee3e5f..1ef0393 100644
--- a/drivers/net/ethernet/qualcomm/qca_spi.c
+++ b/drivers/net/ethernet/qualcomm/qca_spi.c
@@ -811,6 +811,7 @@ qcaspi_netdev_setup(struct net_device *dev)
 	dev->netdev_ops = &qcaspi_netdev_ops;
 	qcaspi_set_ethtool_ops(dev);
 	dev->watchdog_timeo = QCASPI_TX_TIMEOUT;
+	dev->priv_flags &= ~IFF_TX_SKB_SHARING;
 	dev->tx_queue_len = 100;
 
 	qca = netdev_priv(dev);
-- 
1.7.9.5

Re: [PATCH 1/2] net: qca_spi: Don't clear IFF_BROADCAST

From: David Miller <davem@davemloft.net>
Date: 2016-02-25 21:14:40 

From: Stefan Wahren <redacted>
Date: Tue, 23 Feb 2016 19:23:23 +0000

Currently qcaspi_netdev_setup accidentally clears IFF_BROADCAST.
So fix this by keeping the flags from ether_setup.

Reported-by: Michael Heimpold <redacted>
Signed-off-by: Stefan Wahren <redacted>
Fixes: 291ab06ecf67 (net: qualcomm: new Ethernet over SPI driver for QCA7000)
Applied and queued up for -stable.

Re: [PATCH 2/2] net: qca_spi: clear IFF_TX_SKB_SHARING

From: David Miller <davem@davemloft.net>
Date: 2016-02-25 21:14:47 

From: Stefan Wahren <redacted>
Date: Tue, 23 Feb 2016 19:23:24 +0000

ether_setup sets IFF_TX_SKB_SHARING but this is not supported by
qca_spi as it modifies the skb on xmit.

Signed-off-by: Stefan Wahren <redacted>
Fixes: 291ab06ecf67 (net: qualcomm: new Ethernet over SPI driver for QCA7000)
Applied and queued up for -stable.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help