[PATCH] et131x: check return value of dma_alloc_coherent

Subsystems: et131x network driver, networking drivers, the rest

STALE3828d

2 messages, 2 authors, 2016-02-18 · open the first message on its own page

[PATCH] et131x: check return value of dma_alloc_coherent

From: Insu Yun <hidden>
Date: 2016-02-16 02:23:53

For error handling, dma_alloc_coherent's return value
needs to be checked, not argument.

Signed-off-by: Insu Yun <redacted>
---
 drivers/net/ethernet/agere/et131x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/agere/et131x.c b/drivers/net/ethernet/agere/et131x.c
index 3f3bcbe..0907ab6 100644
--- a/drivers/net/ethernet/agere/et131x.c
+++ b/drivers/net/ethernet/agere/et131x.c
@@ -2380,7 +2380,7 @@ static int et131x_tx_dma_memory_alloc(struct et131x_adapter *adapter)
 						    sizeof(u32),
 						    &tx_ring->tx_status_pa,
 						    GFP_KERNEL);
-	if (!tx_ring->tx_status_pa) {
+	if (!tx_ring->tx_status) {
 		dev_err(&adapter->pdev->dev,
 			"Cannot alloc memory for Tx status block\n");
 		return -ENOMEM;
-- 
1.9.1

Re: [PATCH] et131x: check return value of dma_alloc_coherent

From: David Miller <davem@davemloft.net>
Date: 2016-02-18 04:32:38

From: Insu Yun <redacted>
Date: Mon, 15 Feb 2016 21:23:47 -0500
For error handling, dma_alloc_coherent's return value
needs to be checked, not argument.

Signed-off-by: Insu Yun <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help