possible patch

2 messages, 2 authors, 2016-02-11 · open the first message on its own page

possible patch

From: Justin Keller <hidden>
Date: 2016-02-11 00:49:14

Hello,
I am new to submitting patches, so sorry if I am doing it wrong. My idea was
to change line 147 in drivers/isdn/pcbit/callbacks.c from
if (cbdata->data.setup.CallingPN == NULL) {

to

if (cbdata->data.setup.CallingPN == NULL ||
sizeof(cbdata->data.setup.CallingPN)>sizeof(ictl.parm.setup.phone) {

Justin Keller

Re: possible patch

From: Jonathan Corbet <corbet@lwn.net>
Date: 2016-02-11 01:25:38

On Wed, 10 Feb 2016 19:49:11 -0500
Justin Keller [off-list ref] wrote:
I am new to submitting patches, so sorry if I am doing it wrong. My idea was
to change line 147 in drivers/isdn/pcbit/callbacks.c from
if (cbdata->data.setup.CallingPN == NULL) {

to

if (cbdata->data.setup.CallingPN == NULL ||
sizeof(cbdata->data.setup.CallingPN)>sizeof(ictl.parm.setup.phone) {
If you want to patch the kernel, the best way to describe what you want to
do is to ... send a patch.

Before you do so, though:

- Please read the available documentation, including SubmittingPatches and
  development-process/*

- Prepare a proper changelog saying *why* you want to make this change.
  You are trying to change the ISDN subsystem, which is pretty static
  these days; what current problem are you running into that makes you
  think this change needs to be applied to the kernel?

Thanks,

jon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help