[PATCH] fmvj18x_cs: The MAC address of FMV-J182 is stored at buf[5]

STALE3827d

2 messages, 2 authors, 2016-02-20 · open the first message on its own page

[PATCH] fmvj18x_cs: The MAC address of FMV-J182 is stored at buf[5]

From: Ken Kawasaki <hidden>
Date: 2016-02-20 01:57:22

The MAC address of FMV-J182 is stored at buf[5].

Signed-off-by: Ken Kawasaki <redacted>

---
--- linux-4.4.1/drivers/net/ethernet/fujitsu/fmvj18x_cs.c.orig	2016-02-19 20:48:40.143852346 +0900
+++ linux-4.4.1/drivers/net/ethernet/fujitsu/fmvj18x_cs.c	2016-02-20 10:33:42.137713831 +0900
@@ -469,8 +469,8 @@ static int fmvj18x_config(struct pcmcia_
 		    goto failed;
 	    }
 	    /* Read MACID from CIS */
-	    for (i = 5; i < 11; i++)
-		    dev->dev_addr[i] = buf[i];
+	    for (i = 0; i < 6; i++)
+		    dev->dev_addr[i] = buf[i + 5];
 	    kfree(buf);
 	} else {
 	    if (pcmcia_get_mac_from_cis(link, dev))

Re: [PATCH] fmvj18x_cs: The MAC address of FMV-J182 is stored at buf[5]

From: David Miller <davem@davemloft.net>
Date: 2016-02-20 03:10:18

From: Ken Kawasaki <redacted>
Date: Sat, 20 Feb 2016 10:57:06 +0900
The MAC address of FMV-J182 is stored at buf[5].

Signed-off-by: Ken Kawasaki <redacted>
This is an extremely poor and misleading description of your change.

The original code was accessing the MAC address properly at buf[5] by
starting the iterator 'i' at 5.

The bug is that the indexing of dev->dev_addr[] is incorrect.

Please describe your change more accurately and resubmit this patch.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help