[PATCH net] geneve: clear IFF_TX_SKB_SHARING

Subsystems: networking drivers, the rest

STALE3831d

2 messages, 2 authors, 2016-02-18 · open the first message on its own page

[PATCH net] geneve: clear IFF_TX_SKB_SHARING

From: Jiri Benc <hidden>
Date: 2016-02-17 14:31:52

ether_setup sets IFF_TX_SKB_SHARING but this is not supported by geneve as
it modifies the skb on xmit.

Signed-off-by: Jiri Benc <redacted>
---
 drivers/net/geneve.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index 028e3873c310..085b27cefb74 100644
--- a/drivers/net/geneve.c
+++ b/drivers/net/geneve.c
@@ -1161,6 +1161,7 @@ static void geneve_setup(struct net_device *dev)
 	dev->hw_features |= NETIF_F_GSO_SOFTWARE;
 
 	netif_keep_dst(dev);
+	dev->priv_flags &= ~IFF_TX_SKB_SHARING;
 	dev->priv_flags |= IFF_LIVE_ADDR_CHANGE | IFF_NO_QUEUE;
 	eth_hw_addr_random(dev);
 }
-- 
1.8.3.1

Re: [PATCH net] geneve: clear IFF_TX_SKB_SHARING

From: David Miller <davem@davemloft.net>
Date: 2016-02-18 19:56:05

From: Jiri Benc <redacted>
Date: Wed, 17 Feb 2016 15:31:35 +0100
ether_setup sets IFF_TX_SKB_SHARING but this is not supported by geneve as
it modifies the skb on xmit.

Signed-off-by: Jiri Benc <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help