[PATCH net-next] bnx2x: Add missing HSI for big-endian machines

Subsystems: broadcom bnx2x 10 gigabit ethernet driver, networking drivers, the rest

STALE3856d

4 messages, 3 authors, 2016-02-19 · open the first message on its own page

[PATCH net-next] bnx2x: Add missing HSI for big-endian machines

From: Yuval Mintz <hidden>
Date: 2016-02-17 11:15:26

Commit e5d3a51cefbb "bnx2x: extend DCBx support" was missing HSI changes
for big-endian machine, breaking compilation on such platforms.

Reported-by: kbuild test robot <redacted>
Signed-off-by: Yuval Mintz <redacted>
---
Hi Dave,

Sorry about this. Please consider applying this to `net-next'.

Thanks,
Yuval
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h
index dd9d6e6..04523d4 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h
@@ -1824,10 +1824,12 @@ struct dcbx_app_priority_entry {
 	u8  pri_bitmap;
 	u8  appBitfield;
 	#define DCBX_APP_ENTRY_VALID         0x01
-	#define DCBX_APP_ENTRY_SF_MASK       0x30
+	#define DCBX_APP_ENTRY_SF_MASK       0xF0
 	#define DCBX_APP_ENTRY_SF_SHIFT      4
 	#define DCBX_APP_SF_ETH_TYPE         0x10
 	#define DCBX_APP_SF_PORT             0x20
+	#define DCBX_APP_SF_UDP              0x40
+	#define DCBX_APP_SF_DEFAULT          0x80
 #elif defined(__LITTLE_ENDIAN)
 	u8 appBitfield;
 	#define DCBX_APP_ENTRY_VALID         0x01
-- 
1.9.3

Re: [PATCH net-next] bnx2x: Add missing HSI for big-endian machines

From: Sergei Shtylyov <hidden>
Date: 2016-02-17 14:01:50

Hello.

On 2/17/2016 2:15 PM, Yuval Mintz wrote:
Commit e5d3a51cefbb "bnx2x: extend DCBx support" was missing HSI changes
    You forgot to also enclose the commit summary in parens.
for big-endian machine, breaking compilation on such platforms.

Reported-by: kbuild test robot <redacted>
Signed-off-by: Yuval Mintz <redacted>
[...]

MBR, Sergei

RE: [PATCH net-next] bnx2x: Add missing HSI for big-endian machines

From: Yuval Mintz <hidden>
Date: 2016-02-17 14:39:50

quoted
Commit e5d3a51cefbb "bnx2x: extend DCBx support" was missing HSI
changes
    You forgot to also enclose the commit summary in parens.
Good to see we've managed to fix everything else.
:-)

Re: [PATCH net-next] bnx2x: Add missing HSI for big-endian machines

From: David Miller <davem@davemloft.net>
Date: 2016-02-19 04:33:56

From: Yuval Mintz <redacted>
Date: Wed, 17 Feb 2016 13:15:14 +0200
Commit e5d3a51cefbb "bnx2x: extend DCBx support" was missing HSI changes
for big-endian machine, breaking compilation on such platforms.

Reported-by: kbuild test robot <redacted>
Signed-off-by: Yuval Mintz <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help