DORMANTno replies

[PATCH net v4] r8169: Remove duplicate of RTL_FEATURE_WOL

From: Corcodel Marian <hidden>
Date: 2016-02-10 04:22:10
Subsystem: 8169 10/100/1000 gigabit ethernet driver, networking drivers, the rest · Maintainers: Heiner Kallweit, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

This patch remove multiple invocation of RTL_FEATURE_WOL.

Signed-off-by: Corcodel Marian <redacted>
---
 drivers/net/ethernet/realtek/r8169.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 17d5571..1f75478 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -8289,18 +8289,20 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	case RTL_GIGA_MAC_VER_49:
 	case RTL_GIGA_MAC_VER_50:
 	case RTL_GIGA_MAC_VER_51:
-		if (rtl_eri_read(tp, 0xdc, ERIAR_EXGMAC) & MagicPacket_v2)
-			tp->features |= RTL_FEATURE_WOL;
-		if ((RTL_R8(Config3) & LinkUp) != 0)
-			tp->features |= RTL_FEATURE_WOL;
+		if (rtl_eri_read(tp, 0xdc, ERIAR_EXGMAC) & MagicPacket_v2) {
+			if ((RTL_R8(Config5) & (UWF | BWF | MWF)) != 0) {
+				if ((RTL_R8(Config3) & LinkUp) != 0)
+					tp->features |= RTL_FEATURE_WOL;
+			}
+		}
 		break;
 	default:
-		if ((RTL_R8(Config3) & (LinkUp | MagicPacket)) != 0)
-			tp->features |= RTL_FEATURE_WOL;
+		if ((RTL_R8(Config3) & (LinkUp | MagicPacket)) != 0) {
+			if ((RTL_R8(Config5) & (UWF | BWF | MWF)) != 0)
+				tp->features |= RTL_FEATURE_WOL;
+		}
 		break;
 	}
-	if ((RTL_R8(Config5) & (UWF | BWF | MWF)) != 0)
-		tp->features |= RTL_FEATURE_WOL;
 	tp->features |= rtl_try_msi(tp, cfg);
 	RTL_W8(Cfg9346, Cfg9346_Lock);
 
-- 
2.5.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help