[PATCH] tcp_memcontrol: Forward declare cgroup_subsys and mem_cgroup stucts

Subsystems: networking [general], the rest

STALE3863d

2 messages, 2 authors, 2016-01-17 · open the first message on its own page

[PATCH] tcp_memcontrol: Forward declare cgroup_subsys and mem_cgroup stucts

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2016-01-17 14:09:04

In file included from net/ipv4/tcp_ipv4.c:77 (and many more):
include/net/tcp_memcontrol.h:5: warning: ‘struct cgroup_subsys’ declared inside parameter list
include/net/tcp_memcontrol.h:5: warning: its scope is only this definition or declaration, which is probably not what you want

Add forward declarations for all used structures to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 include/net/tcp_memcontrol.h | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/include/net/tcp_memcontrol.h b/include/net/tcp_memcontrol.h
index 3a17b16ae8aa47c4..01ff7c6efada9797 100644
--- a/include/net/tcp_memcontrol.h
+++ b/include/net/tcp_memcontrol.h
@@ -1,6 +1,9 @@
 #ifndef _TCP_MEMCG_H
 #define _TCP_MEMCG_H
 
+struct cgroup_subsys;
+struct mem_cgroup;
+
 int tcp_init_cgroup(struct mem_cgroup *memcg, struct cgroup_subsys *ss);
 void tcp_destroy_cgroup(struct mem_cgroup *memcg);
 #endif /* _TCP_MEMCG_H */
-- 
1.9.1

Re: [PATCH] tcp_memcontrol: Forward declare cgroup_subsys and mem_cgroup stucts

From: David Miller <davem@davemloft.net>
Date: 2016-01-17 17:02:51

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Sun, 17 Jan 2016 11:30:37 +0100
In file included from net/ipv4/tcp_ipv4.c:77 (and many more):
include/net/tcp_memcontrol.h:5: warning: ‘struct cgroup_subsys’ declared inside parameter list
include/net/tcp_memcontrol.h:5: warning: its scope is only this definition or declaration, which is probably not what you want

Add forward declarations for all used structures to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied, thanks Geert.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help