[patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB

Subsystems: mellanox ethernet switch drivers, networking drivers, the rest

STALE3867d

4 messages, 4 authors, 2016-01-13 · open the first message on its own page

[patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB

From: Dan Carpenter <hidden>
Date: 2016-01-13 12:28:50

There is a missing break statement so we always return -EOPNOTSUPP.

Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
index ffe894e..45479ef 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
@@ -1015,6 +1015,7 @@ static int mlxsw_sp_port_obj_del(struct net_device *dev,
 	case SWITCHDEV_OBJ_ID_PORT_MDB:
 		err = mlxsw_sp_port_mdb_del(mlxsw_sp_port,
 					    SWITCHDEV_OBJ_PORT_MDB(obj));
+		break;
 	default:
 		err = -EOPNOTSUPP;
 		break;

Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB

From: Jiri Pirko <jiri@resnulli.us>
Date: 2016-01-13 13:38:17

Wed, Jan 13, 2016 at 01:28:23PM CET, dan.carpenter@oracle.com wrote:
There is a missing break statement so we always return -EOPNOTSUPP.

Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
Signed-off-by: Dan Carpenter <redacted>
Acked-by: Jiri Pirko <redacted>

Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB

From: David Miller <davem@davemloft.net>
Date: 2016-01-13 15:35:34

From: Dan Carpenter <redacted>
Date: Wed, 13 Jan 2016 15:28:23 +0300
There is a missing break statement so we always return -EOPNOTSUPP.

Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
Signed-off-by: Dan Carpenter <redacted>
Applied.

Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB

From: Elad Raz <hidden>
Date: 2016-01-13 17:04:14

On Jan 13, 2016, at 2:28 PM, Dan Carpenter [off-list ref] wrote:

There is a missing break statement so we always return -EOPNOTSUPP.

Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
Signed-off-by: Dan Carpenter <redacted>
Acked-by: Elad Raz <redacted>
quoted hunk
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
index ffe894e..45479ef 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
@@ -1015,6 +1015,7 @@ static int mlxsw_sp_port_obj_del(struct net_device *dev,
	case SWITCHDEV_OBJ_ID_PORT_MDB:
		err = mlxsw_sp_port_mdb_del(mlxsw_sp_port,
					    SWITCHDEV_OBJ_PORT_MDB(obj));
+		break;
	default:
		err = -EOPNOTSUPP;
		break;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help