[patch 2/2 -next] phy: remove an unneeded condition

Subsystems: ethernet phy library, networking drivers, the rest

STALE3867d

2 messages, 2 authors, 2016-01-12 · open the first message on its own page

[patch 2/2 -next] phy: remove an unneeded condition

From: Dan Carpenter <hidden>
Date: 2016-01-12 09:36:46

It used to be that bus->irq was a pointer but after e7f4dc3536a4
('mdio: Move allocation of interrupts into core') it's an array inside
the mdio struct, so it can never be NULL.  Let's remove the check.

Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 3193006..903737a 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -340,7 +340,7 @@ struct phy_device *phy_device_create(struct mii_bus *bus, int addr, int phy_id,
 	dev->phy_id = phy_id;
 	if (c45_ids)
 		dev->c45_ids = *c45_ids;
-	dev->irq = bus->irq ? bus->irq[addr] : PHY_POLL;
+	dev->irq = bus->irq[addr];
 	dev_set_name(&mdiodev->dev, PHY_ID_FMT, bus->id, addr);
 
 	dev->state = PHY_DOWN;

Re: [patch 2/2 -next] phy: remove an unneeded condition

From: David Miller <davem@davemloft.net>
Date: 2016-01-12 19:31:09

From: Dan Carpenter <redacted>
Date: Tue, 12 Jan 2016 12:36:21 +0300
It used to be that bus->irq was a pointer but after e7f4dc3536a4
('mdio: Move allocation of interrupts into core') it's an array inside
the mdio struct, so it can never be NULL.  Let's remove the check.

Signed-off-by: Dan Carpenter <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help