[PATCH] net: sctp: prevent writes to cookie_hmac_alg from accessing invalid memory

Subsystems: networking [general], sctp protocol, the rest

STALE3871d

2 messages, 2 authors, 2016-01-10 · open the first message on its own page

[PATCH] net: sctp: prevent writes to cookie_hmac_alg from accessing invalid memory

From: Sasha Levin <hidden>
Date: 2016-01-07 19:53:14

proc_dostring() needs an initialized destination string, while the one
provided in proc_sctp_do_hmac_alg() contains stack garbage.

Thus, writing to cookie_hmac_alg would strlen() that garbage and end up
accessing invalid memory.

Fixes: 3c68198e7 ("sctp: Make hmac algorithm selection for cookie generation dynamic")
Signed-off-by: Sasha Levin <redacted>
---
 net/sctp/sysctl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c
index ccbfc93..daf8554 100644
--- a/net/sctp/sysctl.c
+++ b/net/sctp/sysctl.c
@@ -327,7 +327,7 @@ static int proc_sctp_do_hmac_alg(struct ctl_table *ctl, int write,
 	struct ctl_table tbl;
 	bool changed = false;
 	char *none = "none";
-	char tmp[8];
+	char tmp[8] = {0};
 	int ret;
 
 	memset(&tbl, 0, sizeof(struct ctl_table));
-- 
1.7.10.4

Re: [PATCH] net: sctp: prevent writes to cookie_hmac_alg from accessing invalid memory

From: David Miller <davem@davemloft.net>
Date: 2016-01-10 23:01:40

From: Sasha Levin <redacted>
Date: Thu,  7 Jan 2016 14:52:43 -0500
proc_dostring() needs an initialized destination string, while the one
provided in proc_sctp_do_hmac_alg() contains stack garbage.

Thus, writing to cookie_hmac_alg would strlen() that garbage and end up
accessing invalid memory.

Fixes: 3c68198e7 ("sctp: Make hmac algorithm selection for cookie generation dynamic")
Signed-off-by: Sasha Levin <redacted>
Applied and queued up for -stable, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help