Re: [PATCH next] ipvlan: inherit MTU from master device
From: Eric Dumazet <edumazet@google.com>
Date: 2016-01-28 13:13:04
From: Eric Dumazet <edumazet@google.com>
Date: 2016-01-28 13:13:04
On Wed, Jan 27, 2016 at 11:33 PM, Mahesh Bandewar [off-list ref] wrote:
From: Mahesh Bandewar <redacted> When we create IPvlan slave; we use ether_setup() and that sets up default MTU to 1500 while the master device may have lower / different MTU. Any subsequent changes to the masters' MTU are reflected into the slaves' MTU setting. However if those don't happen (most likely scenario), the slaves' MTU stays at 1500 which could be bad. This change adds code to inherit MTU from the master device instead of using the default value during the link initialization phase. Signed-off-by: Mahesh Bandewar <redacted> CC: Eric Dumazet <redacted> CC: Tim Hockins <redacted>
Acked-by: Eric Dumazet <edumazet@google.com> Two points Mahesh : 1) ipvlan_adjust_mtu() could be static, it is only used from drivers/net/ipvlan/ipvlan_main.c 2) mtu_adj does not seem to be used ?