Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

On Tue, Jan 26, 2016 at 2:55 PM, Julian Calaby [off-list ref] wrote:

Hi Cong,

On Wed, Jan 27, 2016 at 4:53 AM, Cong Wang [off-list ref] wrote:

A commit message would be nice. A brief rundown of how this is called
from userspace would be nice (I'm talking a single sentence here, e.g.
"this is allocated when submitting a nfc packet") and what issue
__GFP_NOWARN is fixing. (I'm guessing log spam due to allocation
failures.)

I thought it is obvious. ;) Keep in mind that $subject is one part of commit
message too, so there is a commit message although very short.

I will add it.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Tue, 2016-01-26 at 15:12 -0800, Cong Wang wrote:

On Tue, Jan 26, 2016 at 2:55 PM, Julian Calaby [off-list ref] wrote:

quoted

Hi Cong,

On Wed, Jan 27, 2016 at 4:53 AM, Cong Wang [off-list ref] wrote:

A commit message would be nice. A brief rundown of how this is called
from userspace would be nice (I'm talking a single sentence here, e.g.
"this is allocated when submitting a nfc packet") and what issue
__GFP_NOWARN is fixing. (I'm guessing log spam due to allocation
failures.)

I thought it is obvious. ;) Keep in mind that $subject is one part of commit
message too, so there is a commit message although very short.

I will add it.

BTW, kzalloc() is useless here, since it is followed by

if (memcpy_from_msg(msg_data, msg, len)) {

Also, this file seems to have two spots with the same problem,
in nfc_llcp_send_ui_frame() & nfc_llcp_send_i_frame()