[patch -next] fsl/fman: double free on probe failure

Subsystems: networking drivers, the rest

STALE3904d

2 messages, 2 authors, 2016-01-06 · open the first message on its own page

[patch -next] fsl/fman: double free on probe failure

From: Dan Carpenter <hidden>
Date: 2016-01-06 09:59:10

"priv" is allocated with devm_kzalloc() so freeing it here with kfree()
will lead to a double free.

Fixes: 3933961682a3 ('fsl/fman: Add FMan MAC driver')
Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c
index 743a393..e33d9d2 100644
--- a/drivers/net/ethernet/freescale/fman/mac.c
+++ b/drivers/net/ethernet/freescale/fman/mac.c
@@ -961,7 +961,6 @@ _return_of_node_put:
 	of_node_put(dev_node);
 _return_dev_set_drvdata:
 	kfree(priv->fixed_link);
-	kfree(priv);
 	dev_set_drvdata(dev, NULL);
 _return:
 	return err;

Re: [patch -next] fsl/fman: double free on probe failure

From: David Miller <davem@davemloft.net>
Date: 2016-01-06 20:28:41

From: Dan Carpenter <redacted>
Date: Wed, 6 Jan 2016 12:59:10 +0300
"priv" is allocated with devm_kzalloc() so freeing it here with kfree()
will lead to a double free.

Fixes: 3933961682a3 ('fsl/fman: Add FMan MAC driver')
Signed-off-by: Dan Carpenter <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help