Re: [PATCH] net/macb: add proper header file
From: Gregory CLEMENT <hidden>
Date: 2015-12-17 12:52:22
Hi Sudip, On jeu., déc. 17 2015, Sudip Mukherjee [off-list ref] wrote:
mips allmodconfig build fails with the error:
drivers/net/ethernet/cadence/macb.c: In function 'macb_probe':
drivers/net/ethernet/cadence/macb.c:2908:2: error: implicit declaration of function 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration]
bp->reset_gpio = devm_gpiod_get_optional(&bp->pdev->dev, "phy-reset",
^
drivers/net/ethernet/cadence/macb.c:2909:8: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function)
GPIOD_OUT_HIGH);
^
drivers/net/ethernet/cadence/macb.c:2909:8: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/ethernet/cadence/macb.c: In function 'macb_remove':
drivers/net/ethernet/cadence/macb.c:2979:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
gpiod_set_value(bp->reset_gpio, 0);
^
Add the proper header file to resolve it. A proper fix already has been posted along with the proper device tree bindinsg too: http://marc.info/?l=linux-netdev&m=145034590619620&w=2 Thanks, Gregory
quoted hunk
Fixes: 5833e0526820 ("net/macb: add support for resetting PHY using GPIO") Cc: Gregory CLEMENT <redacted> Signed-off-by: Sudip Mukherjee <redacted> --- build log with next-20151217 is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/97388463 drivers/net/ethernet/cadence/macb.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index 0123646..988ee14 100644 --- a/drivers/net/ethernet/cadence/macb.c +++ b/drivers/net/ethernet/cadence/macb.c@@ -19,6 +19,7 @@ #include <linux/init.h> #include <linux/io.h> #include <linux/gpio.h> +#include <linux/gpio/consumer.h> #include <linux/interrupt.h> #include <linux/netdevice.h> #include <linux/etherdevice.h>-- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com