# RE: \[PATCH net-next\] net, cgroup: cgroup\_sk\_updat\_lock was missing initializer

- From: Dexuan Cui \<hidden\>
- Date: 2015-12-15 02:11:33 
- List: netdev
- Page: https://ratatoskr.run/netdev/2015/12/4642911
- Thread: https://ratatoskr.run/netdev/2015/12/4637114/t.md

```text
> -----Original Message-----
> From: David Miller [mailto:<redacted>]
> Sent: Tuesday, December 15, 2015 3:21
> To: <redacted>
> Cc: Dexuan Cui <redacted>; <redacted>; <redacted>;
> kadlec-K40Dz/62t/MgiyqX0sVFJYdd74u8MsAO@public.gmane.org; daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org; daniel.wagner-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org;
> nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org; lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org; hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org;
> netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> coreteam-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org; cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-
> kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; kernel-team-b10kYP2dOMg@public.gmane.org; ninasc-b10kYP2dOMg@public.gmane.org
> Subject: Re: [PATCH net-next] net, cgroup: cgroup_sk_updat_lock was missing
> initializer
> 
> From: Tejun Heo <redacted>
> Date: Mon, 14 Dec 2015 11:24:06 -0500
> 
> > bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup") added global
> > spinlock cgroup_sk_update_lock but erroneously skipped initializer
> > leading to uninitialized spinlock warning.  Fix it by using
> > DEFINE_SPINLOCK().
> >
> > Signed-off-by: Tejun Heo <redacted>
> > Reported-by: Dexuan Cui <redacted>
> > Fixes: bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup")
> 
> Applied, thanks.

Thanks! I can confirm it fixed the issue.

Thanks,
-- Dexuan
```