DORMANTno replies

[PATCH] i40iw: fix compare_const_fl.cocci warnings

From: Julia Lawall <hidden>
Date: 2015-12-22 08:15:25
Also in: linux-rdma

Move constants to the right of binary operators.

Generated by: scripts/coccinelle/misc/compare_const_fl.cocci

CC: Faisal Latif <redacted>
Signed-off-by: Fengguang Wu <redacted>
Signed-off-by: Julia Lawall <redacted>

---

It's a minor point, but when I first looked at the code, I thought that 
MIN and MAX were inverted, so it could be good to change.

 i40iw_ctrl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
@@ -1664,7 +1664,7 @@ static enum i40iw_status_code i40iw_sc_c
 {
 	u32 pble_obj_cnt;
 
-	if (I40IW_MIN_CQ_SIZE > info->num_elem || I40IW_MAX_CQ_SIZE < info->num_elem)
+	if (info->num_elem < I40IW_MIN_CQ_SIZE || info->num_elem > I40IW_MAX_CQ_SIZE)
 		return I40IW_ERR_INVALID_SIZE;
 
 	if (info->ceq_id > I40IW_MAX_CEQID)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help