# Re: \[PATCH v2\] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree

- From: Kalle Valo \<hidden\>
- Date: 2015-11-30 09:06:12 
- List: netdev
- Page: https://ratatoskr.run/netdev/2015/11/4630769

```text
Kalle Valo [ref] writes:

> Brent Taylor [ref] writes:
>
>> Signed-off-by: Brent Taylor <redacted>
>>
>> ath6kl: Use vmalloc for loading firmware using api1 method and free using kvfree
>> ---
>> Changes v1 -> v2:
>>    - simplify memory allocation
>>    - use kvfree
>
> Why? The commit log should _always_ answer that. Are you fixing a bug
> (what bug exactly?), is this just cleanup or what?
>
> And the commit log is wrongly formatted anyway, the Signed-off-by line
> should be the last and there should be no "ath6kl:" string in the commit
> log (just in the title). Use 'git log' to find examples.

Fixing netdev address (kenrel -> kernel)

-- 
Kalle Valo
```