# Re: \[PATCH 2/5\] kernfs: implement kernfs\_walk\_and\_get()

- From: Tejun Heo \<tj@kernel.org\>
- Date: 2015-11-17 21:22:49 
- List: netdev
- Page: https://ratatoskr.run/netdev/2015/11/4622760
- Thread: https://ratatoskr.run/netdev/2015/11/4622696/t.md

```text
On Tue, Nov 17, 2015 at 04:20:40PM -0500, David Miller wrote:
> From: Tejun Heo <tj@kernel.org>
> Date: Tue, 17 Nov 2015 14:40:37 -0500
> 
> > +	static char path_buf[PATH_MAX];	/* protected by kernfs_mutex */
> > +	int len = strlen(path);
>  ...
> > +	if (len >= PATH_MAX)
> > +		return NULL;
> > +
> > +	memcpy(path_buf, path, len + 1);
> 
> 	static char path_buf[PATH_MAX];	/* protected by kernfs_mutex */
> 	int len = strlcpy(path_buf, path, PATH_MAX);
>  ...
> 	if (len >= PATH_MAX)
> 		return NULL;

That's a lot better.  Will update.

Thanks.

-- 
tejun
```