Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

Mason [off-list ref] writes:

On 10/11/2015 22:51, Eric Dumazet wrote:

quoted

On Tue, 2015-11-10 at 21:21 +0000, Måns Rullgård wrote:

quoted

Even ixgbe uses napi_complete() while netdevice.h says one should
"consider using napi_complete_done() instead."  Did the author consider
it and decide not to, or has the driver simply not been updated?

napi_complete_done() is quite new, very few drivers use it.

I was hoping to back-port this driver for my platform. Are the recent
features used in the driver available in 4.1? What about 3.14?

xmit_more was added in 3.18, napi_complete_done() in 3.19.

-- 
Måns Rullgård
mans@mansr.com

On Wed, 2015-11-11 at 13:54 +0000, Måns Rullgård wrote:

Mason [off-list ref] writes:

quoted

On 10/11/2015 22:51, Eric Dumazet wrote:

quoted

On Tue, 2015-11-10 at 21:21 +0000, Måns Rullgård wrote:

quoted

Even ixgbe uses napi_complete() while netdevice.h says one should
"consider using napi_complete_done() instead."  Did the author consider
it and decide not to, or has the driver simply not been updated?

napi_complete_done() is quite new, very few drivers use it.

I was hoping to back-port this driver for my platform. Are the recent
features used in the driver available in 4.1? What about 3.14?

xmit_more was added in 3.18, napi_complete_done() in 3.19.

xmit_more is a hint, you can simply consider skb->xmit_more being
replaced by 0 on old kernels if you want to backport.