[PATCH 1/3] net: wireless: rt2x00: Space issue
Subsystems:
networking drivers (wireless) , the rest
3865d
7 messages,
3 authors,
2016-02-07 · open the first message on its own page
Removed empty spaces before/after parenthesis
Signed-off-by: Paul McQuade <redacted>
---
drivers/net/wireless/rt2x00/rt2x00.h | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h
index 3282ddb..6f8310a 100644
--- a/drivers/net/wireless/rt2x00/rt2x00.h
+++ b/drivers/net/wireless/rt2x00/rt2x00.h @@ -107,7 +107,7 @@
* amount of bytes needed to move the data .
*/
#define ALIGN_SIZE(__skb, __header) \
- ( (( unsigned long )(( __skb ) -> data + ( __header ))) & 3 ) + ((( unsigned long )(( __skb ) -> data + ( __header ))) & 3 )
/*
* Constants for extra TX headroom for alignment purposes . @@ -128,14 +128,14 @@
#define SLOT_TIME 20
#define SHORT_SLOT_TIME 9
#define SIFS 10
- #define PIFS ( SIFS + SLOT_TIME ) - #define SHORT_PIFS ( SIFS + SHORT_SLOT_TIME ) - #define DIFS ( PIFS + SLOT_TIME ) - #define SHORT_DIFS ( SHORT_PIFS + SHORT_SLOT_TIME ) - #define EIFS ( SIFS + DIFS + \ - GET_DURATION ( IEEE80211_HEADER + ACK_SIZE , 10 ) ) - #define SHORT_EIFS ( SIFS + SHORT_DIFS + \ - GET_DURATION ( IEEE80211_HEADER + ACK_SIZE , 10 ) ) + #define PIFS (SIFS + SLOT_TIME) + #define SHORT_PIFS (SIFS + SHORT_SLOT_TIME) + #define DIFS (PIFS + SLOT_TIME) + #define SHORT_DIFS (SHORT_PIFS + SHORT_SLOT_TIME) + #define EIFS (SIFS + DIFS + \ + GET_DURATION ( IEEE80211_HEADER + ACK_SIZE , 10 )) + #define SHORT_EIFS (SIFS + SHORT_DIFS + \ + GET_DURATION ( IEEE80211_HEADER + ACK_SIZE , 10 ))
enum rt2x00_chip_intf {
RT2X00_CHIP_INTF_PCI ,
--
2.6.1
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Code Style: pointer is declared wrong
Signed-off-by: Paul McQuade <redacted>
---
drivers/net/wireless/rt2x00/rt2x00.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h
index 6f8310a..b052e87 100644
--- a/drivers/net/wireless/rt2x00/rt2x00.h
+++ b/drivers/net/wireless/rt2x00/rt2x00.h @@ -380,7 +380,7 @@ struct rt2x00_intf {
atomic_t seqno ;
};
- static inline struct rt2x00_intf * vif_to_intf ( struct ieee80211_vif * vif ) + static inline struct rt2x00_intf * vif_to_intf ( struct ieee80211_vif * vif ) {
return ( struct rt2x00_intf * ) vif -> drv_priv ;
} @@ -507,7 +507,7 @@ struct rt2x00_sta {
int wcid ;
};
- static inline struct rt2x00_sta * sta_to_rt2x00_sta ( struct ieee80211_sta * sta ) + static inline struct rt2x00_sta * sta_to_rt2x00_sta ( struct ieee80211_sta * sta ) {
return ( struct rt2x00_sta * ) sta -> drv_priv ;
} --
2.6.1
Space needed before open parenthesis
Signed-off-by: Paul McQuade <redacted>#
---
drivers/net/wireless/rt2x00/rt2x00debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c
index 90fdb02..25ee3cb 100644
--- a/drivers/net/wireless/rt2x00/rt2x00debug.c
+++ b/drivers/net/wireless/rt2x00/rt2x00debug.c @@ -629,7 +629,7 @@ static struct dentry *rt2x00debug_create_file_chipset(const char *name,
data += sprintf ( data , "register \t base \t words \t wordsize \n " );
#define RT2X00DEBUGFS_SPRINTF_REGISTER(__name) \
{ \
- if ( debug -> __name . read ) \+ if ( debug -> __name . read ) \ data += sprintf ( data , __stringify ( __name ) \
" \t %d \t %d \t %d \n " , \
debug -> __name . word_base , \ @@ -699,7 +699,7 @@ void rt2x00debug_register(struct rt2x00_dev *rt2x00dev)
#define RT2X00DEBUGFS_CREATE_REGISTER_ENTRY(__intf, __name) \
({ \
- if ( debug -> __name . read ) { \+ if ( debug -> __name . read ) { \ ( __intf ) -> __name ## _off_entry = \
debugfs_create_u32 ( __stringify ( __name ) "_offset" , \
S_IRUSR | S_IWUSR , \ --
2.6.1
On Sat, Oct 17, 2015 at 11:06 PM, Paul McQuade [off-list ref] wrote: Code Style: pointer is declared wrong
Signed-off-by: Paul McQuade <redacted>
Thanks for fixing this code style issue.
Acked-by: Helmut Schaa <redacted>
quoted hunk ---
drivers/net/wireless/rt2x00/rt2x00.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h
index 6f8310a..b052e87 100644
--- a/drivers/net/wireless/rt2x00/rt2x00.h
+++ b/drivers/net/wireless/rt2x00/rt2x00.h @@ -380,7 +380,7 @@ struct rt2x00_intf {
atomic_t seqno ;
};
- static inline struct rt2x00_intf * vif_to_intf ( struct ieee80211_vif * vif ) + static inline struct rt2x00_intf * vif_to_intf ( struct ieee80211_vif * vif ) {
return ( struct rt2x00_intf * ) vif -> drv_priv ;
} @@ -507,7 +507,7 @@ struct rt2x00_sta {
int wcid ;
};
- static inline struct rt2x00_sta * sta_to_rt2x00_sta ( struct ieee80211_sta * sta ) + static inline struct rt2x00_sta * sta_to_rt2x00_sta ( struct ieee80211_sta * sta ) {
return ( struct rt2x00_sta * ) sta -> drv_priv ;
}
- - 2.6.1
On Sat, Oct 17, 2015 at 11:06 PM, Paul McQuade [off-list ref] wrote: Removed empty spaces before/after parenthesis
Signed-off-by: Paul McQuade <redacted>
Looks valid to me as well.
Acked-by: Helmut Schaa <redacted>
quoted hunk ---
drivers/net/wireless/rt2x00/rt2x00.h | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h
index 3282ddb..6f8310a 100644
--- a/drivers/net/wireless/rt2x00/rt2x00.h
+++ b/drivers/net/wireless/rt2x00/rt2x00.h @@ -107,7 +107,7 @@
* amount of bytes needed to move the data .
*/
#define ALIGN_SIZE(__skb, __header) \
- ( (( unsigned long )(( __skb ) -> data + ( __header ))) & 3 ) + ((( unsigned long )(( __skb ) -> data + ( __header ))) & 3 ) /*
* Constants for extra TX headroom for alignment purposes . @@ -128,14 +128,14 @@
#define SLOT_TIME 20
#define SHORT_SLOT_TIME 9
#define SIFS 10
- #define PIFS ( SIFS + SLOT_TIME ) - #define SHORT_PIFS ( SIFS + SHORT_SLOT_TIME ) - #define DIFS ( PIFS + SLOT_TIME ) - #define SHORT_DIFS ( SHORT_PIFS + SHORT_SLOT_TIME ) - #define EIFS ( SIFS + DIFS + \ - GET_DURATION ( IEEE80211_HEADER + ACK_SIZE , 10 ) ) - #define SHORT_EIFS ( SIFS + SHORT_DIFS + \ - GET_DURATION ( IEEE80211_HEADER + ACK_SIZE , 10 ) ) + #define PIFS (SIFS + SLOT_TIME) + #define SHORT_PIFS (SIFS + SHORT_SLOT_TIME) + #define DIFS (PIFS + SLOT_TIME) + #define SHORT_DIFS (SHORT_PIFS + SHORT_SLOT_TIME) + #define EIFS (SIFS + DIFS + \ + GET_DURATION ( IEEE80211_HEADER + ACK_SIZE , 10 )) + #define SHORT_EIFS (SIFS + SHORT_DIFS + \ + GET_DURATION ( IEEE80211_HEADER + ACK_SIZE , 10 )) enum rt2x00_chip_intf {
RT2X00_CHIP_INTF_PCI ,
- - 2.6.1
Removed empty spaces before/after parenthesis
Signed-off-by: Paul McQuade <redacted>
Acked-by: Helmut Schaa <redacted>
Thanks, 2 patches applied to wireless-drivers-next.git:
b2cc2dd8ebb8 net: wireless: rt2x00: Space issue
5b451715e94d net: wireless: rt2x00: Space Required
1 patches skipped:
[2/3] net: wireless: rt2x00: Pointer issue
Kalle Valo
Code Style: pointer is declared wrong
Signed-off-by: Paul McQuade <redacted>
Acked-by: Helmut Schaa <redacted>
This patch didn't apply, so please resend.
Kalle