# Re: \[PATCH 1/2\] regmap: only call custom reg\_update\_bits() if reg is marked volatile

- From: Mark Brown \<broonie@kernel.org\>
- Date: 2015-10-05 15:38:12 
- List: netdev
- Page: https://ratatoskr.run/netdev/2015/10/4590481
- Thread: https://ratatoskr.run/netdev/2015/10/4590399/t.md

```text
On Mon, Oct 05, 2015 at 09:29:31AM -0400, jon@ringle.org wrote:
> From: Jon Ringle <redacted>
> 
> The only time that it makes sense to call a custom provided reg_update_bits
> function, is the register being updated is one that has volatile bits.
> Otherwise, the normal read/modify/write cycle (where the read is likely to
> be free from the cache) will do just fine. This should keep the reg cache
> intact, since volatile registers won't get cached anyway.

Dave, to be clear please do *not* apply this patch at least for the time
being - I've not reviewed it or the one from Thursday that you applied
this morning.
```

## Attachments

- [signature.asc](https://ratatoskr.run/netdev/2015/10/4590481/attachment/0) (application/pgp-signature, 473 bytes)
