# Re: \[PATCH 01/12\] net: fec: avoid timespec use

- From: Richard Cochran \<richardcochran@gmail.com\>
- Date: 2015-10-01 19:08:16 
- List: netdev
- Page: https://ratatoskr.run/netdev/2015/10/4588508
- Thread: https://ratatoskr.run/netdev/2015/09/4586972/t.md

```text
On Wed, Sep 30, 2015 at 01:26:31PM +0200, Arnd Bergmann wrote:
> The fec_ptp_enable_pps uses an open-coded implementation of ns_to_timespec,
> which will be removed eventually as it is not y2038-safe on 32-bit
> architectures. Two more instances of the same code in this file were
> already converted to use the safe ns_to_timespec64 in commit 6630514fcee
> ("ptp: fec: use helpers for converting ns to timespec"), this changes
> the last one as well.
> 
> The seconds portion here is actually unused and we could just remove the
> timespec variable, but using ns_to_timespec64 can still be better as the
> implementation can be hand-optimized in the future.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Richard Cochran <richardcochran@gmail.com>
```