On 15-09-30 02:37 PM, Florian Fainelli wrote:

On 30/09/15 13:32, Arun Parameswaran wrote:

quoted

Add support for the Broadcom Cygnus SoCs internal PHY's.
The PHYs are 1000M/100M/10M capable with support for 'EEE'
and 'APD' (Auto Power Down).

This driver supports the following Broadcom Cygnus SoCs:
 - BCM583XX (BCM58300, BCM58302, BCM58303, BCM58305)
 - BCM113XX (BCM11300, BCM11320, BCM11350, BCM11360)

The PHY's on these SoC's require some workarounds for
stable operation, both during configuration time and
during suspend/resume. This driver handles the
application of the workarounds.

Signed-off-by: Arun Parameswaran <redacted>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Some suggestions if you need to respin this patch series below, sorry
for not catching that during the internal review:

quoted

+/* Broadcom Cygnus Phy specific registers */
+#define MII_BCM_CORE_BASE1E       0x1E /* Core BASE1E register */
+#define MII_BCM_EXPB0             0xB0 /* EXPB0 register */
+#define MII_BCM_EXPB1             0xB1 /* EXPB1 register */

These defines could be moved to brcmphy.h for instance, since they are
shared between all Broadcom PHY drivers AFAICT.

Ok, Will move these and modify the corresponding PHY drivers.

Thanks,
Arun