# Re: \[PATCH V4 1/2\] ACPI / EC: Fix broken 64bit big-endian users of 'global\_lock'

- From: Rafael J. Wysocki \<hidden\>
- Date: 2015-09-25 19:54:23 
- List: netdev
- Page: https://ratatoskr.run/netdev/2015/09/4583862
- Thread: https://ratatoskr.run/linux-arm-kernel/2015/09/4583751/t.md

```text
On Friday, September 25, 2015 10:18:13 PM Rafael J. Wysocki wrote:
> On Friday, September 25, 2015 09:41:37 AM Viresh Kumar wrote:
> > global_lock is defined as an unsigned long and accessing only its lower
> > 32 bits from sysfs is incorrect, as we need to consider other 32 bits
> > for big endian 64 bit systems. There are no such platforms yet, but the
> > code needs to be robust for such a case.
> > 
> > Fix that by passing a local variable to debugfs_create_bool() and
> > assigning its value to global_lock later.
> > 
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> Acked-by: Rafael J. Wysocki <redacted>
> 
> Greg, please take this one if the [2/2] looks good to you.

Ouch, turns out it was a bad idea.  Please scratch that.

Thanks,
Rafael

```