# Re: \[PATCH net\] bridge: fix igmpv3 / mldv2 report parsing

- From: David Miller \<davem@davemloft.net\>
- Date: 2015-09-11 22:09:08 
- List: netdev
- Page: https://ratatoskr.run/netdev/2015/09/4573976
- Thread: https://ratatoskr.run/netdev/2015/09/4573816/t.md

```text
From: Linus Lüssing <redacted>
Date: Fri, 11 Sep 2015 18:39:48 +0200

> With the newly introduced helper functions the skb pulling is hidden in
> the checksumming function - and undone before returning to the caller.
> 
> The IGMPv3 and MLDv2 report parsing functions in the bridge still
> assumed that the skb is pointing to the beginning of the IGMP/MLD
> message while it is now kept at the beginning of the IPv4/6 header,
> breaking the message parsing and creating packet loss.
> 
> Fixing this by taking the offset between IP and IGMP/MLD header into
> account, too.
> 
> Fixes: 9afd85c9e455 ("net: Export IGMP/MLD message validation code")
> Reported-by: Tobias Powalowski <redacted>
> Tested-by: Tobias Powalowski <redacted>
> Signed-off-by: Linus Lüssing <redacted>

There were many serious regressions introduced by that commit, I'm
extremely disappointed.

Patch applied and queued up for -stable, thanks.
```